From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: kvm-ppc@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] powerpc: Fix parallel build
Date: Wed, 30 Mar 2016 18:12:45 +0200 [thread overview]
Message-ID: <56FBFAFD.3040203@redhat.com> (raw)
In-Reply-To: <1459344713-20394-1-git-send-email-thuth@redhat.com>
On 30/03/2016 15:31, Thomas Huth wrote:
> kvm-unit-tests can currently not be build in parallel for powerpc.
> For example with "make -j4", I get:
>
> In file included from lib/asm/../../powerpc/asm/ppc_asm.h:4:0,
> from lib/asm/ppc_asm.h:1,
> from lib/powerpc/setup.c:19:
> lib/asm/asm-offsets.h:1:35: fatal error: generated/asm-offsets.h: No such file or directory
>
> Fix it by adding a proper dependency to the Makefile (cstart64.S
> needs this generated header file), and by removing an unnecessary
> include-statement in lib/powerpc/setup.c.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> lib/powerpc/setup.c | 1 -
> powerpc/Makefile.common | 2 ++
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/powerpc/setup.c b/lib/powerpc/setup.c
> index e3cf952..353c7d4 100644
> --- a/lib/powerpc/setup.c
> +++ b/lib/powerpc/setup.c
> @@ -16,7 +16,6 @@
> #include <alloc.h>
> #include <asm/setup.h>
> #include <asm/page.h>
> -#include <asm/ppc_asm.h>
> #include <asm/hcall.h>
>
> extern unsigned long stacktop;
> diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
> index 4ffb829..4449aec 100644
> --- a/powerpc/Makefile.common
> +++ b/powerpc/Makefile.common
> @@ -68,6 +68,8 @@ generated_files = $(asm-offsets)
>
> test_cases: $(generated_files) $(tests-common) $(tests)
>
> +$(cstart.o): $(asm-offsets)
> +
> $(TEST_DIR)/selftest.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/selftest.o
>
> $(TEST_DIR)/spapr_hcall.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/spapr_hcall.o
>
Thanks, applying soon.
Paolo
prev parent reply other threads:[~2016-03-30 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 13:31 [kvm-unit-tests PATCH] powerpc: Fix parallel build Thomas Huth
2016-03-30 16:12 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FBFAFD.3040203@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).