From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] powerpc: Fix parallel build
Date: Wed, 30 Mar 2016 18:12:45 +0200
Message-ID: <56FBFAFD.3040203@redhat.com>
References: <1459344713-20394-1-git-send-email-thuth@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: kvm-ppc@vger.kernel.org
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f67.google.com ([74.125.82.67]:34673 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752388AbcC3QMs (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 30 Mar 2016 12:12:48 -0400
In-Reply-To: <1459344713-20394-1-git-send-email-thuth@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 30/03/2016 15:31, Thomas Huth wrote:
> kvm-unit-tests can currently not be build in parallel for powerpc.
> For example with "make -j4", I get:
> 
> In file included from lib/asm/../../powerpc/asm/ppc_asm.h:4:0,
>                  from lib/asm/ppc_asm.h:1,
>                  from lib/powerpc/setup.c:19:
> lib/asm/asm-offsets.h:1:35: fatal error: generated/asm-offsets.h: No such file or directory
> 
> Fix it by adding a proper dependency to the Makefile (cstart64.S
> needs this generated header file), and by removing an unnecessary
> include-statement in lib/powerpc/setup.c.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  lib/powerpc/setup.c     | 1 -
>  powerpc/Makefile.common | 2 ++
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/powerpc/setup.c b/lib/powerpc/setup.c
> index e3cf952..353c7d4 100644
> --- a/lib/powerpc/setup.c
> +++ b/lib/powerpc/setup.c
> @@ -16,7 +16,6 @@
>  #include <alloc.h>
>  #include <asm/setup.h>
>  #include <asm/page.h>
> -#include <asm/ppc_asm.h>
>  #include <asm/hcall.h>
>  
>  extern unsigned long stacktop;
> diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
> index 4ffb829..4449aec 100644
> --- a/powerpc/Makefile.common
> +++ b/powerpc/Makefile.common
> @@ -68,6 +68,8 @@ generated_files = $(asm-offsets)
>  
>  test_cases: $(generated_files) $(tests-common) $(tests)
>  
> +$(cstart.o): $(asm-offsets)
> +
>  $(TEST_DIR)/selftest.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/selftest.o
>  
>  $(TEST_DIR)/spapr_hcall.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/spapr_hcall.o
> 

Thanks, applying soon.

Paolo