From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH kvm-unit-tests v7 5/5] scripts: automatically pretty print
 stacks
Date: Fri, 1 Apr 2016 10:38:02 +0200
Message-ID: <56FE336A.9030705@redhat.com>
References: <cover.1458689655.git.pfeiner@google.com>
 <e0d998a8adabdb7a88c9b2c608911e0fc3260e36.1458689655.git.pfeiner@google.com>
 <56FA635A.5000307@redhat.com> <20160331233317.GA31870@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: drjones@redhat.com, kvm@vger.kernel.org
To: Peter Feiner <pfeiner@google.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f66.google.com ([74.125.82.66]:36598 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751379AbcDAIiI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 1 Apr 2016 04:38:08 -0400
Received: by mail-wm0-f66.google.com with SMTP id 20so2790509wmh.3
        for <kvm@vger.kernel.org>; Fri, 01 Apr 2016 01:38:08 -0700 (PDT)
In-Reply-To: <20160331233317.GA31870@google.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 01/04/2016 01:33, Peter Feiner wrote:
>> > 
>> > On 23/03/2016 00:35, Peter Feiner wrote:
>>> > > +if [ "$PRETTY_PRINT_STACKS" = "yes" ]; then
>>> > > +	log_redir="> >(./scripts/pretty_print_stacks.py \$kernel >> test.log)"
>> > 
>> > Isn't this the same as "| ./scripts/pretty_print_stack.py \$kernel >>
>> > test.log"?
> Not the same. Consider scripts/runtime.bash's usage:
> 
> 	cmdline="...$RUNTIME_arch_run $kernel -smp $smp $opts"
> 
> With your alternative, the command-line arguments after $RUNTIME_arch_run
> are be passed to pretty_print_stacks.py instead of Qemu.

Ok, I'll add a comment then.

Paolo