From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 17/31] kvm: teach kvm to map page teams as huge pages. Date: Wed, 6 Apr 2016 08:47:00 +0200 Message-ID: <5704B0E4.9060300@redhat.com> References: <57044C3A.7060109@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Andrew Morton , "Kirill A. Shutemov" , Andrea Arcangeli , Andres Lagar-Cavilla , Yang Shi , Ning Qu , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org To: Hugh Dickins Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: kvm.vger.kernel.org On 06/04/2016 03:12, Hugh Dickins wrote: > Hah, you've lighted on precisely a line of code where I changed around > what Andres had - I thought it nicer to pass down vcpu, because that > matched the function above, and in many cases vcpu is not dereferenced > here at all. So, definitely blame me not Andres for that interface. > Oh, actually I'm fine with the interface if it's in arch/x86/kvm. I'm just pointing out that---putting aside the locking question---it's a pretty generic thing that doesn't really need access to KVM data structures. Paolo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org