From: Thomas Huth <thuth@redhat.com>
To: Alexander Gordeev <agordeev@redhat.com>, kvm@vger.kernel.org
Cc: Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH RFC 05/15] pci/x86: Rename pci_config_read() to pci_config_readl()
Date: Wed, 13 Apr 2016 14:55:39 +0200 [thread overview]
Message-ID: <570E41CB.5020701@redhat.com> (raw)
In-Reply-To: <fd7d8a810450b2e9d7f0f77eea47031753eed362.1460190352.git.agordeev@redhat.com>
On 11.04.2016 13:04, Alexander Gordeev wrote:
> This is needed to facilitate other-sized PCI configuration
> space accessors, not just 32 bit one.
>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
> lib/pci.c | 8 ++++----
> lib/x86/asm/pci.h | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
...
> diff --git a/lib/x86/asm/pci.h b/lib/x86/asm/pci.h
> index 4ec20e17d25b..d10a32c38dd5 100644
> --- a/lib/x86/asm/pci.h
> +++ b/lib/x86/asm/pci.h
> @@ -9,7 +9,7 @@
> #include "pci.h"
> #include "x86/io.h"
>
> -static inline uint32_t pci_config_read(pcidevaddr_t dev, uint8_t reg)
> +static inline uint32_t pci_config_readl(pcidevaddr_t dev, uint8_t reg)
> {
> uint32_t index = reg | (dev << 8) | (0x1 << 31);
> outl(index, 0xCF8);
Did you consider "pci_config_read32" instead? ... that would be even
more clear about the size. Anyway, I'm also fine with "readl", so:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2016-04-13 12:55 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 11:04 [PATCH RFC 00/15] PCI bus support Alexander Gordeev
2016-04-11 11:04 ` [PATCH RFC 01/15] Update ioremap() prototype to conform to the Linux one Alexander Gordeev
2016-04-11 11:34 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 02/15] x86: Add basic ioremap() implementation Alexander Gordeev
2016-04-11 11:45 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 03/15] x86/vmexit: Make use of ioremap() Alexander Gordeev
2016-04-11 11:46 ` Andrew Jones
2016-04-11 12:02 ` Alexander Gordeev
2016-04-11 11:04 ` [PATCH RFC 04/15] pci: Fix indentation in generic PCI files Alexander Gordeev
2016-04-11 11:50 ` Andrew Jones
2016-04-11 12:06 ` Alexander Gordeev
2016-04-11 12:21 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 05/15] pci/x86: Rename pci_config_read() to pci_config_readl() Alexander Gordeev
2016-04-11 11:51 ` Andrew Jones
2016-04-13 12:55 ` Thomas Huth [this message]
2016-04-14 13:13 ` Alexander Gordeev
2016-04-11 11:04 ` [PATCH RFC 06/15] pci/x86: Add remaining PCI configuration space accessors Alexander Gordeev
2016-04-14 7:29 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 07/15] pci: Add pci_probe() and pci_shutdown() Alexander Gordeev
2016-04-14 7:45 ` Thomas Huth
2016-04-14 13:23 ` Alexander Gordeev
2016-04-22 15:04 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 08/15] pci: Rework pci_bar_addr() Alexander Gordeev
2016-04-13 13:28 ` Thomas Huth
2016-04-13 17:46 ` Alexander Gordeev
2016-04-13 18:05 ` Andrew Jones
2016-04-22 15:20 ` Andrew Jones
2016-04-22 15:22 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 09/15] pci: Add pci_bar_set() Alexander Gordeev
2016-04-13 15:01 ` Thomas Huth
2016-04-13 16:38 ` Andrew Jones
2016-04-13 18:39 ` Alexander Gordeev
2016-04-14 7:30 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 10/15] pci: Add pci_print() and pci_type_desc() Alexander Gordeev
2016-04-14 7:43 ` Thomas Huth
2016-04-14 8:34 ` Alexander Gordeev
2016-04-14 8:41 ` Thomas Huth
2016-04-14 9:42 ` Andrew Jones
2016-04-22 15:35 ` Andrew Jones
2016-05-18 9:03 ` Alexander Gordeev
2016-05-23 15:10 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 11/15] pci/x86: Adopt PCI framework changes Alexander Gordeev
2016-04-22 15:37 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 12/15] Factor out generic architecture code Alexander Gordeev
2016-04-14 7:50 ` Thomas Huth
2016-04-14 8:16 ` Alexander Gordeev
2016-04-22 15:40 ` Andrew Jones
2016-04-22 16:14 ` Alexander Gordeev
2016-04-22 15:54 ` Andrew Jones
2016-04-22 16:35 ` Alexander Gordeev
2016-04-26 8:24 ` Alexander Gordeev
2016-04-26 9:37 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 13/15] pci/arm: Add generic ECAM host support Alexander Gordeev
2016-04-22 17:07 ` Andrew Jones
2016-05-29 19:54 ` Alexander Gordeev
2016-05-30 6:12 ` Andrew Jones
2016-05-30 6:28 ` Alexander Gordeev
2016-05-30 6:40 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 14/15] pci: Add pci-testdev PCI bus test device Alexander Gordeev
2016-04-22 17:23 ` Andrew Jones
2016-05-23 8:02 ` Alexander Gordeev
2016-05-23 15:17 ` Andrew Jones
2016-05-29 17:48 ` Alexander Gordeev
2016-05-30 6:09 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 15/15] pci/arm: Add pci-testdev PCI device operation test Alexander Gordeev
2016-04-22 17:33 ` Andrew Jones
2016-05-29 20:03 ` Alexander Gordeev
2016-05-30 6:15 ` Andrew Jones
2016-05-31 20:13 ` Alexander Gordeev
2016-05-31 20:27 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E41CB.5020701@redhat.com \
--to=thuth@redhat.com \
--cc=agordeev@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).