From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [PATCH RFC 05/15] pci/x86: Rename pci_config_read() to pci_config_readl() Date: Wed, 13 Apr 2016 14:55:39 +0200 Message-ID: <570E41CB.5020701@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Andrew Jones To: Alexander Gordeev , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45239 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030563AbcDMMzm (ORCPT ); Wed, 13 Apr 2016 08:55:42 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4FD6C116E1D for ; Wed, 13 Apr 2016 12:55:42 +0000 (UTC) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 11.04.2016 13:04, Alexander Gordeev wrote: > This is needed to facilitate other-sized PCI configuration > space accessors, not just 32 bit one. > > Cc: Thomas Huth > Cc: Andrew Jones > Signed-off-by: Alexander Gordeev > --- > lib/pci.c | 8 ++++---- > lib/x86/asm/pci.h | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) ... > diff --git a/lib/x86/asm/pci.h b/lib/x86/asm/pci.h > index 4ec20e17d25b..d10a32c38dd5 100644 > --- a/lib/x86/asm/pci.h > +++ b/lib/x86/asm/pci.h > @@ -9,7 +9,7 @@ > #include "pci.h" > #include "x86/io.h" > > -static inline uint32_t pci_config_read(pcidevaddr_t dev, uint8_t reg) > +static inline uint32_t pci_config_readl(pcidevaddr_t dev, uint8_t reg) > { > uint32_t index = reg | (dev << 8) | (0x1 << 31); > outl(index, 0xCF8); Did you consider "pci_config_read32" instead? ... that would be even more clear about the size. Anyway, I'm also fine with "readl", so: Reviewed-by: Thomas Huth