From: Thomas Huth <thuth@redhat.com>
To: Alexander Gordeev <agordeev@redhat.com>, kvm@vger.kernel.org
Cc: Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH RFC 07/15] pci: Add pci_probe() and pci_shutdown()
Date: Thu, 14 Apr 2016 09:45:57 +0200 [thread overview]
Message-ID: <570F4AB5.9020300@redhat.com> (raw)
In-Reply-To: <d88680cc55e538d01c9539b9b1bbeebd3805fdfc.1460190352.git.agordeev@redhat.com>
On 11.04.2016 13:04, Alexander Gordeev wrote:
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
> lib/asm-generic/pci.h | 15 ++++++++++++++-
> lib/pci.c | 1 -
> lib/pci.h | 2 ++
> 3 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/lib/asm-generic/pci.h b/lib/asm-generic/pci.h
> index 3fa0b2ab1fe6..175b0497ed82 100644
> --- a/lib/asm-generic/pci.h
> +++ b/lib/asm-generic/pci.h
> @@ -1,4 +1,17 @@
> #ifndef _ASM_GENERIC_PCI_H_
> #define _ASM_GENERIC_PCI_H_
> -#error need architecture specific asm/pci.h
> +
> +#ifndef pci_probe
> +static inline bool pci_probe(void)
> +{
> + return true;
> +}
> +#endif
> +
> +#ifndef pci_shutdown
> +static inline void pci_shutdown(void)
> +{
> +}
> +#endif
> +
> #endif
What are these functions supposed to do exactly? (and why is the default
implementation empty?) ... some comments would be really helpful here.
Thomas
next prev parent reply other threads:[~2016-04-14 7:46 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 11:04 [PATCH RFC 00/15] PCI bus support Alexander Gordeev
2016-04-11 11:04 ` [PATCH RFC 01/15] Update ioremap() prototype to conform to the Linux one Alexander Gordeev
2016-04-11 11:34 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 02/15] x86: Add basic ioremap() implementation Alexander Gordeev
2016-04-11 11:45 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 03/15] x86/vmexit: Make use of ioremap() Alexander Gordeev
2016-04-11 11:46 ` Andrew Jones
2016-04-11 12:02 ` Alexander Gordeev
2016-04-11 11:04 ` [PATCH RFC 04/15] pci: Fix indentation in generic PCI files Alexander Gordeev
2016-04-11 11:50 ` Andrew Jones
2016-04-11 12:06 ` Alexander Gordeev
2016-04-11 12:21 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 05/15] pci/x86: Rename pci_config_read() to pci_config_readl() Alexander Gordeev
2016-04-11 11:51 ` Andrew Jones
2016-04-13 12:55 ` Thomas Huth
2016-04-14 13:13 ` Alexander Gordeev
2016-04-11 11:04 ` [PATCH RFC 06/15] pci/x86: Add remaining PCI configuration space accessors Alexander Gordeev
2016-04-14 7:29 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 07/15] pci: Add pci_probe() and pci_shutdown() Alexander Gordeev
2016-04-14 7:45 ` Thomas Huth [this message]
2016-04-14 13:23 ` Alexander Gordeev
2016-04-22 15:04 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 08/15] pci: Rework pci_bar_addr() Alexander Gordeev
2016-04-13 13:28 ` Thomas Huth
2016-04-13 17:46 ` Alexander Gordeev
2016-04-13 18:05 ` Andrew Jones
2016-04-22 15:20 ` Andrew Jones
2016-04-22 15:22 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 09/15] pci: Add pci_bar_set() Alexander Gordeev
2016-04-13 15:01 ` Thomas Huth
2016-04-13 16:38 ` Andrew Jones
2016-04-13 18:39 ` Alexander Gordeev
2016-04-14 7:30 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 10/15] pci: Add pci_print() and pci_type_desc() Alexander Gordeev
2016-04-14 7:43 ` Thomas Huth
2016-04-14 8:34 ` Alexander Gordeev
2016-04-14 8:41 ` Thomas Huth
2016-04-14 9:42 ` Andrew Jones
2016-04-22 15:35 ` Andrew Jones
2016-05-18 9:03 ` Alexander Gordeev
2016-05-23 15:10 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 11/15] pci/x86: Adopt PCI framework changes Alexander Gordeev
2016-04-22 15:37 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 12/15] Factor out generic architecture code Alexander Gordeev
2016-04-14 7:50 ` Thomas Huth
2016-04-14 8:16 ` Alexander Gordeev
2016-04-22 15:40 ` Andrew Jones
2016-04-22 16:14 ` Alexander Gordeev
2016-04-22 15:54 ` Andrew Jones
2016-04-22 16:35 ` Alexander Gordeev
2016-04-26 8:24 ` Alexander Gordeev
2016-04-26 9:37 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 13/15] pci/arm: Add generic ECAM host support Alexander Gordeev
2016-04-22 17:07 ` Andrew Jones
2016-05-29 19:54 ` Alexander Gordeev
2016-05-30 6:12 ` Andrew Jones
2016-05-30 6:28 ` Alexander Gordeev
2016-05-30 6:40 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 14/15] pci: Add pci-testdev PCI bus test device Alexander Gordeev
2016-04-22 17:23 ` Andrew Jones
2016-05-23 8:02 ` Alexander Gordeev
2016-05-23 15:17 ` Andrew Jones
2016-05-29 17:48 ` Alexander Gordeev
2016-05-30 6:09 ` Andrew Jones
2016-04-11 11:04 ` [PATCH RFC 15/15] pci/arm: Add pci-testdev PCI device operation test Alexander Gordeev
2016-04-22 17:33 ` Andrew Jones
2016-05-29 20:03 ` Alexander Gordeev
2016-05-30 6:15 ` Andrew Jones
2016-05-31 20:13 ` Alexander Gordeev
2016-05-31 20:27 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570F4AB5.9020300@redhat.com \
--to=thuth@redhat.com \
--cc=agordeev@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).