From mboxrd@z Thu Jan  1 00:00:00 1970
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Subject: Re: [PART1 RFC v4 01/11] KVM: x86: Misc LAPIC changes to expose
 helper functions
Date: Tue, 19 Apr 2016 03:29:16 +0700
Message-ID: <5715439C.9030307@amd.com>
References: <1460017232-17429-1-git-send-email-Suravee.Suthikulpanit@amd.com>
 <1460017232-17429-2-git-send-email-Suravee.Suthikulpanit@amd.com>
 <20160411203449.GA32480@potion.brq.redhat.com> <57153C18.6020104@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: <pbonzini@redhat.com>, <joro@8bytes.org>, <bp@alien8.de>,
	<gleb@kernel.org>, <alex.williamson@redhat.com>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<wei@redhat.com>, <sherry.hurwitz@amd.com>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bn1on0069.outbound.protection.outlook.com ([157.56.110.69]:15392
	"EHLO na01-bn1-obe.outbound.protection.outlook.com"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1752416AbcDRU32 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 18 Apr 2016 16:29:28 -0400
In-Reply-To: <57153C18.6020104@amd.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 04/19/2016 02:57 AM, Suravee Suthikulpanit wrote:
> Radim,
>
> On 04/12/2016 03:34 AM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
>> 2016-04-07 03:20-0500, Suravee Suthikulpanit:
>>> Exporting LAPIC utility functions and macros for re-use in SVM code=
=2E
>>>
>>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com=
>
>>> ---
>>
>> Adding kvm_lapic_set_reg looks weird when KVM has kvm_apic_get_reg, =
but
>> the structure they accept is called kvm_lapic, so I vote to rename g=
et,
>>
>> Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
>>
>
> Sure. Within the same patch, I can rename kvm_apic_get_reg to
> kvm_lapic_get_reg to be consistent.
>

Think again, I'll do this on a separate patch.

Suravee