kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: kvm@vger.kernel.org, Eric Auger <eric.auger@linaro.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/45] KVM: arm/arm64: Rework virtual GIC emulation
Date: Tue, 19 Apr 2016 13:04:34 +0100	[thread overview]
Message-ID: <57161ED2.6000701@arm.com> (raw)
In-Reply-To: <1461061586-15012-1-git-send-email-andre.przywara@arm.com>

On 19/04/16 11:26, Andre Przywara wrote:
> Hi Vladimir,
> 
> can you try the attached patch on top of the series to see if this
> fixes the GICv3 emulation issues you see?
> 

With attached patch I don't see issue any more - all 255 vcpus are able
to boot and send/receive self SGI.

Thanks
Vladimir

> I think these lines got lost during the MMIO framework rebasing.
> 
> Cheers,
> Andre.
> 
> ---
>  virt/kvm/arm/vgic/vgic_mmio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/virt/kvm/arm/vgic/vgic_mmio.c b/virt/kvm/arm/vgic/vgic_mmio.c
> index ec96188..92f39ba 100644
> --- a/virt/kvm/arm/vgic/vgic_mmio.c
> +++ b/virt/kvm/arm/vgic/vgic_mmio.c
> @@ -1228,6 +1228,7 @@ int vgic_register_redist_iodevs(struct kvm *kvm, gpa_t redist_base_address)
>  	kvm_for_each_vcpu(c, vcpu, kvm) {
>  		kvm_iodevice_init(&region->dev, &kvm_io_v3redist_ops);
>  		region->base_addr = redist_base_address;
> +		region->redist_vcpu = vcpu;
>  
>  		mutex_lock(&kvm->slots_lock);
>  		ret = kvm_io_bus_register_dev(kvm, KVM_MMIO_BUS,
> @@ -1241,6 +1242,7 @@ int vgic_register_redist_iodevs(struct kvm *kvm, gpa_t redist_base_address)
>  		region++;
>  		kvm_iodevice_init(&region->dev, &kvm_io_v3redist_private_ops);
>  		region->base_addr = redist_base_address + SZ_64K;
> +		region->redist_vcpu = vcpu;
>  
>  		mutex_lock(&kvm->slots_lock);
>  		ret = kvm_io_bus_register_dev(kvm, KVM_MMIO_BUS,
> 


      reply	other threads:[~2016-04-19 12:04 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 17:11 [PATCH 00/45] KVM: arm/arm64: Rework virtual GIC emulation Andre Przywara
2016-04-15 17:11 ` [PATCH 01/45] KVM: arm/arm64: Get rid of vgic_cpu->nr_lr Andre Przywara
2016-04-15 17:11 ` [PATCH 02/45] KVM: arm/arm64: Fix MMIO emulation data handling Andre Przywara
2016-04-15 17:11 ` [PATCH 03/45] KVM: arm/arm64: pmu: abstract access to number of SPIs Andre Przywara
2016-04-15 17:11 ` [PATCH 04/45] KVM: arm/arm64: vgic-new: Add data structure definitions Andre Przywara
2016-04-15 17:11 ` [PATCH 05/45] KVM: arm/arm64: vgic-new: Add acccessor to new struct vgic_irq instance Andre Przywara
2016-04-25 16:15   ` Andrew Jones
2016-04-25 19:49     ` Christoffer Dall
2016-04-26  8:21       ` Marc Zyngier
2016-04-26  9:44         ` Andrew Jones
2016-04-26 18:42           ` Christoffer Dall
2016-04-15 17:11 ` [PATCH 06/45] KVM: arm/arm64: vgic-new: Implement virtual IRQ injection Andre Przywara
2016-04-15 17:11 ` [PATCH 07/45] KVM: arm/arm64: vgic-new: Add IRQ sorting Andre Przywara
2016-04-15 17:11 ` [PATCH 08/45] KVM: arm/arm64: vgic-new: Add IRQ sync/flush framework Andre Przywara
2016-04-15 17:11 ` [PATCH 09/45] KVM: arm/arm64: vgic-new: Add GICv2 world switch backend Andre Przywara
2016-04-15 17:11 ` [PATCH 10/45] KVM: arm/arm64: vgic-new: Add GICv3 " Andre Przywara
2016-04-15 17:11 ` [PATCH 11/45] KVM: arm/arm64: vgic-new: Implement kvm_vgic_vcpu_pending_irq Andre Przywara
2016-04-15 17:11 ` [PATCH 12/45] KVM: arm/arm64: vgic-new: Add MMIO handling framework Andre Przywara
2016-04-15 17:11 ` [PATCH 13/45] KVM: arm/arm64: vgic-new: Export register access interface Andre Przywara
2016-04-15 17:11 ` [PATCH 14/45] KVM: arm/arm64: vgic-new: Add CTLR, TYPER and IIDR handlers Andre Przywara
2016-04-15 17:11 ` [PATCH 15/45] KVM: arm/arm64: vgic-new: Add ENABLE registers handlers Andre Przywara
2016-04-15 17:11 ` [PATCH 16/45] KVM: arm/arm64: vgic-new: Add PENDING " Andre Przywara
2016-04-15 17:11 ` [PATCH 17/45] KVM: arm/arm64: vgic-new: Add PRIORITY " Andre Przywara
2016-04-15 17:11 ` [PATCH 18/45] KVM: arm/arm64: vgic-new: Add ACTIVE " Andre Przywara
2016-04-15 17:11 ` [PATCH 19/45] KVM: arm/arm64: vgic-new: Add CONFIG " Andre Przywara
2016-04-15 17:11 ` [PATCH 20/45] KVM: arm/arm64: vgic-new: Add TARGET " Andre Przywara
2016-04-15 17:11 ` [PATCH 21/45] KVM: arm/arm64: vgic-new: Add SGIR register handler Andre Przywara
2016-04-15 17:11 ` [PATCH 22/45] KVM: arm/arm64: vgic-new: Add SGIPENDR register handlers Andre Przywara
2016-04-15 17:11 ` [PATCH 23/45] KVM: arm/arm64: vgic-new: Add GICv3 MMIO handling framework Andre Przywara
2016-04-26 10:14   ` Marc Zyngier
2016-04-15 17:11 ` [PATCH 24/45] KVM: arm/arm64: vgic-new: Add GICv3 CTLR, IIDR, TYPER handlers Andre Przywara
2016-04-19 12:26   ` Peter Maydell
2016-04-15 17:11 ` [PATCH 25/45] KVM: arm/arm64: vgic-new: Add GICv3 redistributor " Andre Przywara
2016-04-15 17:11 ` [PATCH 26/45] KVM: arm/arm64: vgic-new: Add GICv3 IDREGS register handler Andre Przywara
2016-04-19 12:34   ` Peter Maydell
2016-04-19 12:57     ` André Przywara
2016-04-19 13:12       ` Peter Maydell
2016-04-15 17:11 ` [PATCH 27/45] KVM: arm/arm64: vgic-new: Add GICv3 IROUTER register handlers Andre Przywara
2016-04-15 17:11 ` [PATCH 28/45] KVM: arm/arm64: vgic-new: Add GICv3 SGI system register trap handler Andre Przywara
2016-04-19 12:40   ` Peter Maydell
2016-04-15 17:11 ` [PATCH 29/45] KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM device ops registration Andre Przywara
2016-04-15 17:11 ` [PATCH 30/45] KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM_DEV_ARM_VGIC_GRP_NR_IRQS Andre Przywara
2016-04-15 17:11 ` [PATCH 31/45] KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM_DEV_ARM_VGIC_GRP_CTRL Andre Przywara
2016-04-15 17:11 ` [PATCH 32/45] KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM_DEV_ARM_VGIC_GRP_ADDR Andre Przywara
2016-04-15 17:11 ` [PATCH 33/45] KVM: arm/arm64: vgic-new: vgic_kvm_device: access to VGIC registers Andre Przywara
2016-04-15 17:11 ` [PATCH 34/45] KVM: arm/arm64: vgic-new: vgic_kvm_device: implement kvm_vgic_addr Andre Przywara
2016-04-15 17:11 ` [PATCH 35/45] KVM: arm/arm64: vgic-new: Add userland access to VGIC dist registers Andre Przywara
2016-04-15 17:11 ` [PATCH 36/45] KVM: arm/arm64: vgic-new: Add GICH_VMCR accessors Andre Przywara
2016-04-15 17:11 ` [PATCH 37/45] KVM: arm/arm64: vgic-new: Add userland GIC CPU interface access Andre Przywara
2016-04-15 17:11 ` [PATCH 38/45] KVM: arm/arm64: vgic-new: vgic_init: implement kvm_vgic_hyp_init Andre Przywara
2016-04-15 17:11 ` [PATCH 39/45] KVM: arm/arm64: vgic-new: vgic_init: implement vgic_create Andre Przywara
2016-04-15 17:11 ` [PATCH 40/45] KVM: arm/arm64: vgic-new: vgic_init: implement vgic_init Andre Przywara
2016-04-15 17:11 ` [PATCH 41/45] KVM: arm/arm64: vgic-new: vgic_init: implement map_resources Andre Przywara
2016-04-15 17:11 ` [PATCH 42/45] KVM: arm/arm64: vgic-new: Add vgic_v2/v3_enable Andre Przywara
2016-04-15 17:11 ` [PATCH 43/45] KVM: arm/arm64: vgic-new: Wire up irqfd injection Andre Przywara
2016-04-15 17:11 ` [PATCH 44/45] KVM: arm/arm64: vgic-new: implement mapped IRQ handling Andre Przywara
2016-04-15 17:11 ` [PATCH 45/45] KVM: arm/arm64: vgic-new: enable build Andre Przywara
2016-04-18 12:47 ` [PATCH 00/45] KVM: arm/arm64: Rework virtual GIC emulation Vladimir Murzin
2016-04-19 10:26   ` Andre Przywara
2016-04-19 12:04     ` Vladimir Murzin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57161ED2.6000701@arm.com \
    --to=vladimir.murzin@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).