From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 744DDC10F13 for ; Thu, 11 Apr 2019 21:27:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 414A82146F for ; Thu, 11 Apr 2019 21:27:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726694AbfDKV1u (ORCPT ); Thu, 11 Apr 2019 17:27:50 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34160 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726677AbfDKV1u (ORCPT ); Thu, 11 Apr 2019 17:27:50 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3BLEr9l146579 for ; Thu, 11 Apr 2019 17:27:49 -0400 Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rtd7ugqjs-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 11 Apr 2019 17:27:49 -0400 Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Apr 2019 22:27:48 +0100 Received: from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 11 Apr 2019 22:27:46 +0100 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3BLRiIm22741166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2019 21:27:44 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5202078060; Thu, 11 Apr 2019 21:27:44 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 349107805C; Thu, 11 Apr 2019 21:27:43 +0000 (GMT) Received: from [9.80.220.2] (unknown [9.80.220.2]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 11 Apr 2019 21:27:42 +0000 (GMT) Subject: Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs From: Eric Farman To: Halil Pasic , Cornelia Huck Cc: Farhan Ali , linux-s390@vger.kernel.org, Alex Williamson , Pierre Morel , kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-s390x@nongnu.org References: <20190301093902.27799-1-cohuck@redhat.com> <20190301093902.27799-2-cohuck@redhat.com> <9e81af36-ebd2-671b-5256-90e8efaad6f2@linux.ibm.com> <20190408190747.12e3618b.cohuck@redhat.com> <20190410013434.7cea1971@oc2783563651> <4a692c11-edb2-93f9-7d8e-96a73a7ecdae@linux.ibm.com> Date: Thu, 11 Apr 2019 17:27:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4a692c11-edb2-93f9-7d8e-96a73a7ecdae@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19041121-8235-0000-0000-00000E7E3B9B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010911; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000284; SDB=6.01187706; UDB=6.00622150; IPR=6.00968469; MB=3.00026399; MTD=3.00000008; XFM=3.00000015; UTC=2019-04-11 21:27:47 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19041121-8236-0000-0000-0000451C5F12 Message-Id: <571b9f8c-cfb0-704e-ded4-8661a8136876@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-11_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904110137 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 4/10/19 10:59 PM, Eric Farman wrote: > > > On 4/9/19 7:34 PM, Halil Pasic wrote: >> On Mon, 8 Apr 2019 19:07:47 +0200 ...snip... >> I'm just running fio on a pass-through DASD and on some virto-blk disks >> in parallel. My QEMU is today's vfio-ccw-caps from your repo. >> >> I see stuff like this: >> qemu-git: vfio-ccw: wirte I/O region failed with errno=16[1811/7332/0 >> iops] [eta 26m:34s] > > Without knowing what the I/O was that failed, this is a guessing game. > But I encountered something similar just now running fio. > > qemu: > 2019-04-11T02:06:09.524838Z qemu-system-s390x: vfio-ccw: wirte I/O > region failed with errno=16 ...snip... > From the associated I/O, I think this is fixed by a series I am nearly > ready to send for review.  I'll try again with those fixes on top of the > two series here, and report back. So, I've run enough combinations to feel comfortable saying that the error (EBUSY) I saw last night (and presumably the one Halil saw) exists in today's code and is not introduced by this series. It also appears to be addressed by one of the patches in a series I'm working on, but which that series still has some further problems. Sigh, there are too many branches and too many interrupts. - Eric