From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom Hanson <thomas.hanson@linaro.org>
Subject: Re: [PATCH v2 16/54] KVM: arm/arm64: vgic-new: Add IRQ sync/flush
 framework
Date: Thu, 5 May 2016 10:44:26 -0600
Message-ID: <572B786A.7040705@linaro.org>
References: <1461861973-26464-1-git-send-email-andre.przywara@arm.com>
 <1461861973-26464-17-git-send-email-andre.przywara@arm.com>
 <572B7384.2050405@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Eric Auger <eric.auger@linaro.org>, kvmarm@lists.cs.columbia.edu,
	kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
To: Andre Przywara <andre.przywara@arm.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Christoffer Dall <christoffer.dall@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pa0-f49.google.com ([209.85.220.49]:33083 "EHLO
	mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757826AbcEEQod (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 5 May 2016 12:44:33 -0400
Received: by mail-pa0-f49.google.com with SMTP id xk12so38001398pac.0
        for <kvm@vger.kernel.org>; Thu, 05 May 2016 09:44:32 -0700 (PDT)
In-Reply-To: <572B7384.2050405@linaro.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/05/2016 10:23 AM, Tom Hanson wrote:
> On 04/28/2016 10:45 AM, Andre Przywara wrote:
>
> ...
>
>> diff --git a/virt/kvm/arm/vgic/vgic.c b/virt/kvm/arm/vgic/vgic.c
>> index 4fb20fd..a656a12e5 100644
>> --- a/virt/kvm/arm/vgic/vgic.c
>> +++ b/virt/kvm/arm/vgic/vgic.c
>
> ...
>> +static void vgic_prune_ap_list(struct kvm_vcpu *vcpu)
>> +{
>
> ...
>
>> +        /* This interrupt looks like it has to be migrated. */
>> +
>> +        spin_unlock(&irq->irq_lock);
>> +        spin_unlock(&vgic_cpu->ap_list_lock);
>
> If using the suggested (but not provided) higher level function from patch 14 this could be:
>                  vgic_unlock_aplist_irq(, spinlock_t irq);

Oh, bother.  That should be:
             vgic_unlock_aplist_irq(vgic_cpu->ap_list_lock, irq->irq_lock);