From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>, KVM <kvm@vger.kernel.org>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
linux-s390 <linux-s390@vger.kernel.org>,
"Jens Freimann" <jfrei@linux.vnet.ibm.com>,
"David Hildenbrand" <dahi@linux.vnet.ibm.com>,
"Alexander Yarygin" <yarygin@linux.vnet.ibm.com>
Subject: Re: [GIT PULL 04/10] KVM: s390: enable SRS only if enabled for the guest
Date: Mon, 9 May 2016 13:31:12 +0200 [thread overview]
Message-ID: <57307500.80802@de.ibm.com> (raw)
In-Reply-To: <57306DCA.8040605@de.ibm.com>
On 05/09/2016 01:00 PM, Christian Borntraeger wrote:
> On 05/09/2016 12:32 PM, Heiko Carstens wrote:
>> On Mon, May 09, 2016 at 11:20:15AM +0200, Christian Borntraeger wrote:
>>> From: David Hildenbrand <dahi@linux.vnet.ibm.com>
>>>
>>> If we don't have SIGP SENSE RUNNING STATUS enabled for the guest, let's
>>> not enable interpretation so we can correctly report an invalid order.
>>>
>>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>> arch/s390/include/asm/sigp.h | 1 +
>>> arch/s390/kvm/kvm-s390.c | 4 +++-
>>> arch/s390/kvm/sigp.c | 6 ++++++
>>> 3 files changed, 10 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/s390/include/asm/sigp.h b/arch/s390/include/asm/sigp.h
>>> index ec60cf7..35c91da 100644
>>> --- a/arch/s390/include/asm/sigp.h
>>> +++ b/arch/s390/include/asm/sigp.h
>>> @@ -33,6 +33,7 @@
>>> #define SIGP_STATUS_INVALID_PARAMETER 0x00000100UL
>>> #define SIGP_STATUS_INCORRECT_STATE 0x00000200UL
>>> #define SIGP_STATUS_NOT_RUNNING 0x00000400UL
>>> +#define SIGP_STATUS_INVALID_ORDER 0x00000002UL
>>
>> This new define should have been added at the top the list to keep the list
>> sorted. Maybe Paolo or Radim can change this when applying this patch.
>
> Its a signed pull request and I must redo it if requested.
>
>
>
Conny noticed a typo in the subject of patch3. So I will redo the
pull request as we have now 2 things to change.
Christian
next prev parent reply other threads:[~2016-05-09 11:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 9:20 [GIT PULL 00/10] KVM: s390: features and fixes for 4.7 part2 Christian Borntraeger
2016-05-09 9:20 ` [GIT PULL 01/10] KVM: s390: cmma: don't check entry content Christian Borntraeger
2016-05-09 9:20 ` [GIT PULL 02/10] KVM: s390: support NQ only if the facility is enabled for the guest Christian Borntraeger
2016-05-09 9:20 ` [GIT PULL 03/10] KVM: s390: enable PFMFI only if guest hast EDAT1 Christian Borntraeger
2016-05-09 9:20 ` [GIT PULL 04/10] KVM: s390: enable SRS only if enabled for the guest Christian Borntraeger
2016-05-09 10:32 ` Heiko Carstens
2016-05-09 11:00 ` Christian Borntraeger
2016-05-09 11:31 ` Christian Borntraeger [this message]
2016-05-09 9:20 ` [GIT PULL 05/10] KVM: s390: cleanup cpuid handling Christian Borntraeger
2016-05-09 9:20 ` [GIT PULL 06/10] KVM: s390: force ibc into valid range Christian Borntraeger
2016-05-09 9:20 ` [GIT PULL 07/10] KVM: s390: document KVM_CAP_S390_RI Christian Borntraeger
2016-05-09 9:20 ` [GIT PULL 08/10] KVM: s390: Enable all facility bits that are known good for passthrough Christian Borntraeger
2016-05-09 9:20 ` [GIT PULL 09/10] s390/sclp: Add hmfai field Christian Borntraeger
2016-05-09 9:20 ` [GIT PULL 10/10] KVM: s390: Populate mask of non-hypervisor managed facility bits Christian Borntraeger
-- strict thread matches above, loose matches on Subject: below --
2016-05-09 12:26 [GIT PULL 00/10] KVM: s390: features and fixes for 4.7 part2 Christian Borntraeger
2016-05-09 12:26 ` [GIT PULL 04/10] KVM: s390: enable SRS only if enabled for the guest Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57307500.80802@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=yarygin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox