From: Thomas Huth <thuth@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 2/2] lib/util,arm,powerpc: replace parse_keyval with better helpers
Date: Thu, 12 May 2016 15:27:05 +0200 [thread overview]
Message-ID: <573484A9.2060108@redhat.com> (raw)
In-Reply-To: <20160512132209.GC5864@potion>
On 12.05.2016 15:22, Radim Krčmář wrote:
> 2016-05-12 10:09+0200, Laurent Vivier:
>> I don't know if it can help, but instead of creating our own API,
>> perhaps we can implement getopt() and getopt_long() and use them?
>
> A known API is a good idea as long I'm not the one implementing it. :)
>
>> Or is it over-engineered?
>
> Yeah, getopt would make both callers and the library more complicated.
We could maybe use the implementation from SLOF:
http://git.qemu.org/?p=SLOF.git;a=blob;f=lib/libc/getopt/getopt.c;h=be626ddc290ee84b3605
It's BSD-licensed, so I think it should be ok to use it
in kvm-unit-tests?
Thomas
next prev parent reply other threads:[~2016-05-12 13:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 20:55 [kvm-unit-tests PATCH 0/2] lib,arm,powerpc: change command line parsing Radim Krčmář
2016-05-11 20:55 ` [kvm-unit-tests PATCH 1/2] lib/string: add strncmp Radim Krčmář
2016-05-12 7:02 ` Laurent Vivier
2016-05-11 20:55 ` [kvm-unit-tests PATCH 2/2] lib/util,arm,powerpc: replace parse_keyval with better helpers Radim Krčmář
2016-05-12 7:19 ` Andrew Jones
2016-05-12 8:05 ` Andrew Jones
2016-05-12 8:09 ` Laurent Vivier
2016-05-12 13:22 ` Radim Krčmář
2016-05-12 13:27 ` Thomas Huth [this message]
2016-05-12 13:17 ` Radim Krčmář
2016-05-12 13:00 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573484A9.2060108@redhat.com \
--to=thuth@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox