From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH v2 1/2] arm/arm64: Makefile cleanup Date: Tue, 17 May 2016 14:35:21 +0200 Message-ID: <573B1009.10805@redhat.com> References: <1462899344-7703-1-git-send-email-drjones@redhat.com> <1462899344-7703-2-git-send-email-drjones@redhat.com> <20160514133040.GA20422@vultr.guest> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, lvivier@redhat.com, thuth@redhat.com To: Wei Yang , Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56997 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627AbcEQMfc (ORCPT ); Tue, 17 May 2016 08:35:32 -0400 In-Reply-To: <20160514133040.GA20422@vultr.guest> Sender: kvm-owner@vger.kernel.org List-ID: On 14/05/2016 15:30, Wei Yang wrote: > On Tue, May 10, 2016 at 06:55:43PM +0200, Andrew Jones wrote: >> This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS >> is used (as opposed to .SECONDARY), because .SECONDARY doesn't >> accept target patterns. >> >> Signed-off-by: Andrew Jones > > Is it possible to add > > Reviewed-by: Wei Yang Too late, sorry; the commit has been pushed already. Paolo > Now? > >> --- >> arm/Makefile.common | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arm/Makefile.common b/arm/Makefile.common >> index 9a2d61fc88a27..a786fcf94154f 100644 >> --- a/arm/Makefile.common >> +++ b/arm/Makefile.common >> @@ -24,6 +24,9 @@ CFLAGS += -Wextra >> CFLAGS += -O2 >> CFLAGS += -I lib -I lib/libfdt >> >> +# We want to keep intermediate files >> +.PRECIOUS: %.elf %.o >> + >> asm-offsets = lib/$(ARCH)/asm-offsets.h >> include scripts/asm-offsets.mak >> >> @@ -48,7 +51,7 @@ start_addr := $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offset) ))) >> >> FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi) >> %.elf: LDFLAGS = $(CFLAGS) -nostdlib >> -%.elf: %.o $(FLATLIBS) arm/flat.lds >> +%.elf: %.o $(FLATLIBS) arm/flat.lds $(cstart.o) >> $(CC) $(LDFLAGS) -o $@ \ >> -Wl,-T,arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \ >> $(filter %.o, $^) $(FLATLIBS) >> @@ -69,7 +72,4 @@ generated_files = $(asm-offsets) >> >> test_cases: $(generated_files) $(tests-common) $(tests) >> >> -$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o >> -$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o >> - >> $(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets) >> -- >> 2.4.11 >