Re: [kvm-unit-tests PATCH 1/9] s390x: topology: Fix report message

[Nina Schoetterl-Glausch <nsg@linux.ibm.com>]

On Wed, 2023-10-11 at 12:56 +0200, Janosch Frank wrote:
> On 10/11/23 10:56, Nina Schoetterl-Glausch wrote:
> > A polarization value of 0 means horizontal polarization.
> > 
> > Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> 
> Don't we need to remove the entitlement part?
> Entitlement is defined as the degree of vertical polarization.

I don't follow.
We're checking this from the PoP:
A dedicated CPU is either horizontally or vertically
polarized. When a dedicated CPU is vertically polar-
ized, entitlement is always high. Thus, when D is one,
PP is either 00 binary or 11 binary. 

> > ---
> >   s390x/topology.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/s390x/topology.c b/s390x/topology.c
> > index 69558236..53838ed1 100644
> > --- a/s390x/topology.c
> > +++ b/s390x/topology.c
> > @@ -275,7 +275,7 @@ static uint8_t *check_tle(void *tc)
> >   	if (!cpus->d)
> >   		report_skip("Not dedicated");
> >   	else
> > -		report(cpus->pp == 3 || cpus->pp == 0, "Dedicated CPUs are either vertically polarized or have high entitlement");
> > +		report(cpus->pp == 3 || cpus->pp == 0, "Dedicated CPUs are either horizontally polarized or have high entitlement");
> >   
> >   	return tc + sizeof(*cpus);
> >   }
>