kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Itaru Kitayama <itaru.kitayama@linux.dev>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	kvm@vger.kernel.org, Joey Gouly <joey.gouly@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Eric Auger <eric.auger@redhat.com>
Subject: Re: [PATCH 4/4] KVM: arm64: selftest: vgic-v3: Add basic GICv3 sysreg userspace access test
Date: Wed, 23 Jul 2025 17:46:14 +0900	[thread overview]
Message-ID: <576D387F-15E6-46C1-BA32-34FB64551CBA@linux.dev> (raw)
In-Reply-To: <87qzy7tja1.wl-maz@kernel.org>



> On Jul 23, 2025, at 17:15, Marc Zyngier <maz@kernel.org> wrote:
> 
> On Wed, 23 Jul 2025 06:00:40 +0100,
> Itaru Kitayama <itaru.kitayama@linux.dev> wrote:
>> 
>> On Fri, Jul 18, 2025 at 12:11:54PM +0100, Marc Zyngier wrote:
>>> We have a lot of more or less useful vgic tests, but none of them
>>> tracks the availability of GICv3 system registers, which is a bit
>>> annoying.
>>> 
>>> Add one such test, which covers both EL1 and EL2 registers.
>>> 
>>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>> 
>> I've tested this selftest on the RevC FVP with kvm-arm.mode=nested.
>> 
>> Tested-by: Itaru Kitayama <itaru.kitayama@fujitsu.com>
>> 
>> Running GIC_v3 tests.
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='672'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='657'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='672'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='672'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='672'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='672'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='682'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='682'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='657'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='672'
>> __vm_create: mode='PA-bits:40,  VA-bits:48,  4K pages' type='0', pages='657'
> 
> I have no idea what you tested it on, because I get none of this
> nonsense.
> 
> Where is it coming from?

From lib/kvm_util.c file __vm_create()’s pr_debug().

Anyway, I rebuilt the kernel your recent two patch sets on top of kvm-next/next and did the test. 

# ./arm64/vgic_init
Random seed: 0x6b8b4567
Running GIC_v3 tests.
SKIP SYS_ICC_AP0R1_EL1 for read
SKIP SYS_ICC_AP0R1_EL1 for write
SKIP SYS_ICC_AP0R2_EL1 for read
SKIP SYS_ICC_AP0R2_EL1 for write
SKIP SYS_ICC_AP0R3_EL1 for read
SKIP SYS_ICC_AP0R3_EL1 for write
SKIP SYS_ICC_AP1R1_EL1 for read
SKIP SYS_ICC_AP1R1_EL1 for write
SKIP SYS_ICC_AP1R2_EL1 for read
SKIP SYS_ICC_AP1R2_EL1 for write
SKIP SYS_ICC_AP1R3_EL1 for read
SKIP SYS_ICC_AP1R3_EL1 for write
SKIP SYS_ICH_AP0R1_EL2 for read
SKIP SYS_ICH_AP0R1_EL2 for write
SKIP SYS_ICH_AP0R2_EL2 for read
SKIP SYS_ICH_AP0R2_EL2 for write
SKIP SYS_ICH_AP0R3_EL2 for read
SKIP SYS_ICH_AP0R3_EL2 for write
SKIP SYS_ICH_AP1R1_EL2 for read
SKIP SYS_ICH_AP1R1_EL2 for write
SKIP SYS_ICH_AP1R2_EL2 for read
SKIP SYS_ICH_AP1R2_EL2 for write
SKIP SYS_ICH_AP1R3_EL2 for read
SKIP SYS_ICH_AP1R3_EL2 for write

Thanks,
Itaru.

> M.
> 
> -- 
> Jazz isn't dead. It just smells funny.



  reply	other threads:[~2025-07-23  8:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 11:11 [PATCH 0/4] KVM: arm64: Userspace GICv3 sysreg access fixes and testing Marc Zyngier
2025-07-18 11:11 ` [PATCH 1/4] KVM: arm64: vgic-v3: Fix ordering of ICH_HCR_EL2 Marc Zyngier
2025-07-23 15:38   ` Sebastian Ott
2025-07-18 11:11 ` [PATCH 2/4] KVM: arm64: Clarify the check for reset callback in check_sysreg_table() Marc Zyngier
2025-07-23 15:38   ` Sebastian Ott
2025-07-18 11:11 ` [PATCH 3/4] KVM: arm64: Enforce the sorting of the GICv3 system register table Marc Zyngier
2025-07-23 15:40   ` Sebastian Ott
2025-07-18 11:11 ` [PATCH 4/4] KVM: arm64: selftest: vgic-v3: Add basic GICv3 sysreg userspace access test Marc Zyngier
2025-07-23  5:00   ` Itaru Kitayama
2025-07-23  8:15     ` Marc Zyngier
2025-07-23  8:46       ` Itaru Kitayama [this message]
2025-07-23 15:56   ` Sebastian Ott
2025-07-28 17:15 ` [PATCH 0/4] KVM: arm64: Userspace GICv3 sysreg access fixes and testing Oliver Upton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576D387F-15E6-46C1-BA32-34FB64551CBA@linux.dev \
    --to=itaru.kitayama@linux.dev \
    --cc=eric.auger@redhat.com \
    --cc=joey.gouly@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=suzuki.poulose@arm.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).