From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Joerg Roedel <joro@8bytes.org>
Cc: <rkrcmar@redhat.com>, <alex.williamson@redhat.com>,
<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sherry.hurwitz@amd.com>
Subject: Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support
Date: Tue, 5 Jul 2016 13:51:46 -0500 [thread overview]
Message-ID: <577C01C2.1010706@amd.com> (raw)
In-Reply-To: <c282dff4-0078-33c0-020c-fb1220f7efa1@redhat.com>
Hi Paolo,
On 6/21/16 10:15, Paolo Bonzini wrote:
>
>
> On 21/06/2016 15:50, Joerg Roedel wrote:
>> The code has a few style issues (thing I'd implemented differently), but
>> it looks functional. Anyway, before merging this the last 3 patches need
>> to be acked by the KVM maintainers.
>>
>> Paolo?
>
> I think patches 9 and 10 should be squashed because the code after patch
> 9 is only partly functional.
>
> Likewise, I think this:
>
>
> +
> + if (AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir))
> + amd_iommu_irq_ops.capability |= (1 << IRQ_POSTING_CAP);
>
> from patch 1 should be moved to patch 6.
I think you might have meant patch 7 instead of 6 since that is when we
enable vAPIC mode in the IOMMU.
Thanks,
Suravee
prev parent reply other threads:[~2016-07-05 18:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 22:06 [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 01/10] iommu/amd: Detect and enable guest vAPIC support Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 02/10] iommu/amd: Add support for 128-bit IRTE Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 03/10] iommu/amd: Detect and initialize guest vAPIC log Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 04/10] iommu/amd: Adding GALOG interrupt handler Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 05/10] iommu/amd: Introduce amd_iommu_update_ga() Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 06/10] iommu/amd: Implements irq_set_vcpu_affinity() hook to setup vapic mode for pass-through devices Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 07/10] iommu/amd: Enable vAPIC interrupt remapping mode by default Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 08/10] svm: Introduce AMD IOMMU avic_ga_log_notifier Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 09/10] svm: Implements update_pi_irte hook to setup posted interrupt Suravee Suthikulpanit
2016-06-13 22:06 ` [PART2 RFC v2 10/10] svm: Update AMD IOMMU IRTE with vcpu scheduling information when enable AVIC Suravee Suthikulpanit
2016-06-21 13:50 ` [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support Joerg Roedel
2016-06-21 14:27 ` Suravee Suthikulanit
2016-06-21 14:46 ` Joerg Roedel
2016-06-21 15:45 ` Suravee Suthikulanit
2016-06-21 15:15 ` Paolo Bonzini
2016-07-05 18:51 ` Suravee Suthikulpanit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577C01C2.1010706@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=alex.williamson@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sherry.hurwitz@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox