From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers Date: Mon, 11 Jul 2016 14:36:34 +0200 Message-ID: <578392D2.6050704@de.ibm.com> References: <1467839703-11733-1-git-send-email-sergey.fedorov@linaro.org> <1467839703-11733-3-git-send-email-sergey.fedorov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: MTTCG Devel , =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= , Alvise Rigo , "Emilio G. Cota" , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , Richard Henderson , Peter Maydell , Peter Crosthwaite , Eduardo Habkost , "Michael S. Tsirkin" , David Gibson , Alexander Graf , Marcelo Tosatti , Cornelia Huck , qemu-ppc@nongnu.org, kvm@vger.kernel.org To: Sergey Fedorov , qemu-devel@nongnu.org Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47758 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933784AbcGKMhD (ORCPT ); Mon, 11 Jul 2016 08:37:03 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6BCY0RG062564 for ; Mon, 11 Jul 2016 08:36:56 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0b-001b2d01.pphosted.com with ESMTP id 243euc83rc-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 11 Jul 2016 08:36:56 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 11 Jul 2016 13:36:54 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id CE8BC2190066 for ; Mon, 11 Jul 2016 13:36:06 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6BCachJ23658804 for ; Mon, 11 Jul 2016 12:36:38 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u6BBacfA024639 for ; Mon, 11 Jul 2016 05:36:39 -0600 In-Reply-To: <1467839703-11733-3-git-send-email-sergey.fedorov@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: On 07/06/2016 11:14 PM, Sergey Fedorov wrote: > From: Alex Benn=C3=A9e >=20 > CPUState is a fairly common pointer to pass to these helpers. This me= ans > if you need other arguments for the async_run_on_cpu case you end up > having to do a g_malloc to stuff additional data into the routine. Fo= r > the current users this isn't a massive deal but for MTTCG this gets > cumbersome when the only other parameter is often an address. >=20 > This adds the typedef run_on_cpu_func for helper functions which has = an > explicit CPUState * passed as the first parameter. All the users of > run_on_cpu and async_run_on_cpu have had their helpers updated to use > CPUState where available. >=20 > Signed-off-by: Alex Benn=C3=A9e > [Sergey Fedorov: > - eliminate more CPUState in user data; > - remove unnecessary user data passing; > - fix target-s390x/kvm.c and target-s390x/misc_helper.c] > Signed-off-by: Sergey Fedorov > --- >=20 > Changes in v2: > - eliminate more CPUState in user data > - remove unnecessary user data passing > - fix target-s390x/kvm.c and target-s390x/misc_helper.c >=20 > --- > cpus.c | 15 ++++--- > hw/i386/kvm/apic.c | 3 +- > hw/i386/kvmvapic.c | 6 +-- > hw/ppc/ppce500_spin.c | 31 +++++---------- > hw/ppc/spapr.c | 6 +-- > hw/ppc/spapr_hcall.c | 17 ++++---- > include/qom/cpu.h | 8 ++-- > kvm-all.c | 21 ++++------ > target-i386/helper.c | 19 ++++----- > target-i386/kvm.c | 6 +-- > target-s390x/cpu.c | 4 +- > target-s390x/cpu.h | 7 +--- > target-s390x/kvm.c | 98 +++++++++++++++++++++++-------------= ---------- > target-s390x/misc_helper.c | 4 +- > 14 files changed, 108 insertions(+), 137 deletions(-) s390 parts look ok.