From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergey Fedorov <serge.fdrv@gmail.com>
Subject: Re: [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers
Date: Mon, 11 Jul 2016 15:38:14 +0300
Message-ID: <57839336.4010403@gmail.com>
References: <1467839703-11733-1-git-send-email-sergey.fedorov@linaro.org>
 <1467839703-11733-3-git-send-email-sergey.fedorov@linaro.org>
 <578392D2.6050704@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: MTTCG Devel <mttcg@listserver.greensocs.com>,
	=?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>,
	Alvise Rigo <a.rigo@virtualopensystems.com>,
	"Emilio G. Cota" <cota@braap.org>,
	=?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Peter Maydell <peter.maydell@linaro.org>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	Alexander Graf <agraf@suse.de>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-ppc@nongnu.org,
	kvm@vger.kernel.org
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Sergey Fedorov <sergey.fedorov@linaro.org>,
	qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-lf0-f67.google.com ([209.85.215.67]:34142 "EHLO
	mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933617AbcGKMiS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 11 Jul 2016 08:38:18 -0400
Received: by mail-lf0-f67.google.com with SMTP id a10so9096922lfb.1
        for <kvm@vger.kernel.org>; Mon, 11 Jul 2016 05:38:18 -0700 (PDT)
In-Reply-To: <578392D2.6050704@de.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/07/16 15:36, Christian Borntraeger wrote:
> On 07/06/2016 11:14 PM, Sergey Fedorov wrote:
>> From: Alex Benn=C3=A9e <alex.bennee@linaro.org>
>>
>> CPUState is a fairly common pointer to pass to these helpers. This m=
eans
>> if you need other arguments for the async_run_on_cpu case you end up
>> having to do a g_malloc to stuff additional data into the routine. F=
or
>> the current users this isn't a massive deal but for MTTCG this gets
>> cumbersome when the only other parameter is often an address.
>>
>> This adds the typedef run_on_cpu_func for helper functions which has=
 an
>> explicit CPUState * passed as the first parameter. All the users of
>> run_on_cpu and async_run_on_cpu have had their helpers updated to us=
e
>> CPUState where available.
>>
>> Signed-off-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
>> [Sergey Fedorov:
>>  - eliminate more CPUState in user data;
>>  - remove unnecessary user data passing;
>>  - fix target-s390x/kvm.c and target-s390x/misc_helper.c]
>> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
>> ---
>>
>> Changes in v2:
>>  - eliminate more CPUState in user data
>>  - remove unnecessary user data passing
>>  - fix target-s390x/kvm.c and target-s390x/misc_helper.c
>>
>> ---
>>  cpus.c                     | 15 ++++---
>>  hw/i386/kvm/apic.c         |  3 +-
>>  hw/i386/kvmvapic.c         |  6 +--
>>  hw/ppc/ppce500_spin.c      | 31 +++++----------
>>  hw/ppc/spapr.c             |  6 +--
>>  hw/ppc/spapr_hcall.c       | 17 ++++----
>>  include/qom/cpu.h          |  8 ++--
>>  kvm-all.c                  | 21 ++++------
>>  target-i386/helper.c       | 19 ++++-----
>>  target-i386/kvm.c          |  6 +--
>>  target-s390x/cpu.c         |  4 +-
>>  target-s390x/cpu.h         |  7 +---
>>  target-s390x/kvm.c         | 98 +++++++++++++++++++++++------------=
-----------
>>  target-s390x/misc_helper.c |  4 +-
>>  14 files changed, 108 insertions(+), 137 deletions(-)
> s390 parts look ok.

Can this be considered as "Acked-by" or not exactly?

Thanks,
Sergey