From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 7/8] pc: acpi: memhp: nvdimm hotplug support Date: Fri, 15 Jul 2016 15:49:12 +0800 Message-ID: <57889578.10504@linux.intel.com> References: <1468244718-3731-1-git-send-email-guangrong.xiao@linux.intel.com> <1468244718-3731-8-git-send-email-guangrong.xiao@linux.intel.com> <20160714121755.GM15476@stefanha-x1.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Stefan Hajnoczi Return-path: Received: from mga03.intel.com ([134.134.136.65]:36630 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932065AbcGOHxP (ORCPT ); Fri, 15 Jul 2016 03:53:15 -0400 In-Reply-To: <20160714121755.GM15476@stefanha-x1.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 07/14/2016 08:17 PM, Stefan Hajnoczi wrote: > On Mon, Jul 11, 2016 at 09:45:17PM +0800, Xiao Guangrong wrote: >> diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c >> index 73fa62d..d1c2e92 100644 >> --- a/hw/acpi/memory_hotplug.c >> +++ b/hw/acpi/memory_hotplug.c >> @@ -239,11 +239,6 @@ void acpi_memory_plug_cb(HotplugHandler *hotplug_dev, MemHotplugState *mem_st, >> DeviceState *dev, Error **errp) >> { >> MemStatus *mdev; >> - DeviceClass *dc = DEVICE_GET_CLASS(dev); >> - >> - if (!dc->hotpluggable) { >> - return; >> - } >> >> mdev = acpi_memory_slot_status(mem_st, dev, errp); >> if (!mdev) { > > Did you mean to include this hunk in the patch? Looks like something > left over from debugging/prototyping. > As all memory devices, both pc-dimm and nvdimm, have supported hotplug now, i think this chunk can be removed. In fact, this check was introduced by nvdimm. :)