From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Herongguang (Stephen)" <herongguang.he@huawei.com>
Subject: Re: [PATCH] KVM: x86: handle
 KVM_SET_VCPU_EVENTS/KVM_VCPUEVENT_VALID_SMM properly
Date: Sat, 8 Oct 2016 11:31:59 +0800
Message-ID: <57F868AF.7030806@huawei.com>
References: <1474606751-17100-1-git-send-email-herongguang.he@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <quintela@redhat.com>, <amit.shah@redhat.com>,
        <qemu-devel@nongnu.org>, <arei.gonglei@huawei.com>,
        <weidong.huang@huawei.com>
To: <pbonzini@redhat.com>, <rkrcmar@redhat.com>, <kvm@vger.kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from szxga01-in.huawei.com ([58.251.152.64]:65357 "EHLO
        szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752065AbcJHDc6 (ORCPT <rfc822;kvm@vger.kernel.org>);
        Fri, 7 Oct 2016 23:32:58 -0400
In-Reply-To: <1474606751-17100-1-git-send-email-herongguang.he@huawei.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 2016/9/23 12:59, herongguang wrote:
> From: He Rongguang <herongguang.he@huawei.com>
>
> handle KVM_VCPUEVENT_VALID_SMM properly, or kvm-kmod/kernel will crash
> in migration destination in gfn_to_rmap() since kvm_memslots_for_spte_role
> is false, whilst (vcpu->arch.hflags & HF_SMM_MASK) is true
>
> Signed-off-by: herongguang <herongguang.he@huawei.com>
> ---
>   arch/x86/kvm/x86.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 699f872..7ebcb59 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3028,6 +3028,7 @@ static int kvm_vcpu_ioctl_x86_set_vcpu_events(struct kvm_vcpu *vcpu,
>   			else
>   				clear_bit(KVM_APIC_INIT, &vcpu->arch.apic->pending_events);
>   		}
> +		kvm_mmu_reset_context(vcpu);
>   	}
>
>   	kvm_make_request(KVM_REQ_EVENT, vcpu);
>

Hi, do you think this is OK for linux 4.9?