From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20CC9C433EF for ; Fri, 4 Mar 2022 12:41:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233283AbiCDMmK (ORCPT ); Fri, 4 Mar 2022 07:42:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231262AbiCDMmJ (ORCPT ); Fri, 4 Mar 2022 07:42:09 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E908C1B3724; Fri, 4 Mar 2022 04:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646397681; x=1677933681; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TMI1gQuIiE9qVU9EYYItY/+o7scD+fNPZ7hV8jCda1w=; b=ZMa8Yq0WkogyGZgeJX8QUk8XV0h6i7oCqihznP5KF2XJWMTZ5vsX9ihT kVdtgmZINBIO6KeZU8c8mnMFb2Fh2Ck3eoNJuEAhuRDbmJvxfFkSO0CYL Xu++wITKU6A+O2kl4YCHsz0Mqwqp0HriP8IQ7neHW/5lLIik5cAY1l6hA efUpGPG45d1ZyhwJibjRsV5zSPrHjm/d1mvW6UloZCJF/DMd9PHepNlTh sCG+vRpU6Rw5+86BBFAjFBIdkVMeqkZfIYeXR70W9gdjYKHWvnEBdOh/t c94eaCjVolO+H3+39STkUMLMttwtLwAEOFXbs7NzYuDPe5JbVzE5TS1na g==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="254159938" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="254159938" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 04:41:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="576869723" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.92]) ([10.237.72.92]) by orsmga001.jf.intel.com with ESMTP; 04 Mar 2022 04:41:17 -0800 Message-ID: <57bdc43e-4753-66f8-b54b-860be3239026@intel.com> Date: Fri, 4 Mar 2022 14:41:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH V2 02/11] perf/x86: Add support for TSC as a perf event clock Content-Language: en-US To: Peter Zijlstra Cc: Alexander Shishkin , Arnaldo Carvalho de Melo , Jiri Olsa , linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, kvm@vger.kernel.org, H Peter Anvin , Mathieu Poirier , Suzuki K Poulose , Leo Yan References: <20220214110914.268126-1-adrian.hunter@intel.com> <20220214110914.268126-3-adrian.hunter@intel.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 04/03/2022 14:33, Peter Zijlstra wrote: > On Mon, Feb 14, 2022 at 01:09:05PM +0200, Adrian Hunter wrote: >> +u64 perf_hw_clock(void) >> +{ >> + return rdtsc_ordered(); >> +} > > Why the _ordered ? To be on the safe-side - in case it matters. trace_clock_x86_tsc() also uses the ordered variant.