From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jike Song Subject: Re: [v2 3/5] KVM: move kvm_{get|put}_kvm to kvm_host.h Date: Mon, 31 Oct 2016 09:40:26 +0800 Message-ID: <5816A10A.7010203@intel.com> References: <1477771515-18015-1-git-send-email-jike.song@intel.com> <1477771515-18015-4-git-send-email-jike.song@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: alex.williamson@redhat.com, guangrong.xiao@linux.intel.com, kwankhede@nvidia.com, cjia@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mga14.intel.com ([192.55.52.115]:46444 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757581AbcJaBns (ORCPT ); Sun, 30 Oct 2016 21:43:48 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 10/30/2016 04:53 PM, Paolo Bonzini wrote: > On 29/10/2016 22:05, Jike Song wrote: >> So that external users like vfio can call them without introducing >> symbol-level dependency. A destroy() method is introduced to the kvm >> structure so that we don't have to also expose kvm_destroy_vm. > > VFIO does not need kvm_put_kvm, so kvm_destroy_vm need not be exported > (or kvm_put_kvm can remain non-inline). Yes, good point. Will keep kvm_put_kvm. -- Thanks, Jike