From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jike Song <jike.song@intel.com>
Subject: Re: [PATCH v10 01/19] vfio: Mediated device Core driver
Date: Tue, 01 Nov 2016 13:28:57 +0800
Message-ID: <58182819.2050109@intel.com>
References: <1477517366-27871-1-git-send-email-kwankhede@nvidia.com> <1477517366-27871-2-git-send-email-kwankhede@nvidia.com> <5818071F.3020507@intel.com> <20161031214453.49da775c@t450s.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Kirti Wankhede <kwankhede@nvidia.com>, pbonzini@redhat.com,
        kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org,
        kvm@vger.kernel.org, kevin.tian@intel.com,
        bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20161031214453.49da775c@t450s.home>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 11/01/2016 11:44 AM, Alex Williamson wrote:
> On Tue, 01 Nov 2016 11:08:15 +0800
> Jike Song <jike.song@intel.com> wrote:
>> On 10/27/2016 05:29 AM, Kirti Wankhede wrote:
>>> +static int mdev_attach_iommu(struct mdev_device *mdev)
>>> +{
>>> +	int ret;
>>> +	struct iommu_group *group;
>>> +
>>> +	group = iommu_group_alloc();
>>> +	if (IS_ERR(group))
>>> +		return PTR_ERR(group);  
>>
>> Maybe I overthought, but where the iommu_group is released? On successful
>> return you already have a ref, I didn't find an iommu_group_put after that.
> ...
>>> +
>>> +	ret = iommu_group_add_device(group, &mdev->dev);
>>> +	if (ret)
>>> +		goto attach_fail;
>>> +
>>> +	dev_info(&mdev->dev, "MDEV: group_id = %d\n",
>>> +				 iommu_group_id(group));
>>> +attach_fail:
>>> +	iommu_group_put(group);
>>> +	return ret;
>>> +}
>>> +
>>> +static void mdev_detach_iommu(struct mdev_device *mdev)
>>> +{
>>> +	iommu_group_remove_device(&mdev->dev);
> 
> Here.  Adding a device to the group takes a group reference so we can
> 'put' the group to release the reference from the alloc as soon as a
> device is added.  When we remove the device, that reference is removed
> and this should result in a release of the group if all other
> references are balanced.  Thanks,

Now I understand, thanks :)

--
Thanks,
Jike