From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA9EFC76196 for ; Sat, 1 Apr 2023 22:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229729AbjDAWVY convert rfc822-to-8bit (ORCPT ); Sat, 1 Apr 2023 18:21:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjDAWVX (ORCPT ); Sat, 1 Apr 2023 18:21:23 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A03DE12845 for ; Sat, 1 Apr 2023 15:21:20 -0700 (PDT) Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pijay-0004qt-Lt; Sun, 02 Apr 2023 00:21:12 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-riscv@lists.infradead.org, palmer@dabbelt.com, anup@brainfault.org, atishp@atishpatra.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org Cc: vineetg@rivosinc.com, greentime.hu@sifive.com, guoren@linux.alibaba.com, Andy Chiu , Paul Walmsley , Albert Ou , Guo Ren , Conor Dooley , Vincent Chen , Andrew Bresticker , Andy Chiu Subject: Re: [PATCH -next v17 12/20] riscv: signal: check fp-reserved words unconditionally Date: Sun, 02 Apr 2023 00:21:11 +0200 Message-ID: <5898720.alqRGMn8q6@diego> In-Reply-To: <20230327164941.20491-13-andy.chiu@sifive.com> References: <20230327164941.20491-1-andy.chiu@sifive.com> <20230327164941.20491-13-andy.chiu@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Am Montag, 27. März 2023, 18:49:32 CEST schrieb Andy Chiu: > In order to let kernel/user locate and identify an extension context on > the existing sigframe, we are going to utilize reserved space of fp and > encode the information there. And since the sigcontext has already > preserved a space for fp context w or w/o CONFIG_FPU, we move those > reserved words checking/setting routine back into generic code. > > This commit also undone an additional logical change carried by the > refactor commit 007f5c3589578 > ("Refactor FPU code in signal setup/return procedures"). Originally we > did not restore fp context if restoring of gpr have failed. And it was > fine on the other side. In such way the kernel could keep the regfiles > intact, and potentially react at the failing point of restore. > > Signed-off-by: Andy Chiu > Acked-by: Conor Dooley Acked-by: Heiko Stuebner Tested-by: Heiko Stuebner