From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Herongguang (Stephen)" <herongguang.he@huawei.com>
Subject: [BUG/RFC] INIT IPI lost when VM starts
Date: Mon, 20 Mar 2017 22:21:34 +0800
Message-ID: <58CFE56E.9090303@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
To: Paolo Bonzini <pbonzini@redhat.com>, <rkrcmar@redhat.com>,
        <afaerber@suse.de>, <jan.kiszka@siemens.com>,
        <qemu-devel@nongnu.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        <wangxinxin.wang@huawei.com>,
        "weidong.huang@huawei.com >> Huangweidong (C)"
        <weidong.huang@huawei.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from szxga02-in.huawei.com ([45.249.212.188]:4344 "EHLO
        dggrg02-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1754469AbdCTOWj (ORCPT
        <rfc822;kvm@vger.kernel.org>); Mon, 20 Mar 2017 10:22:39 -0400
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi,
We encountered a problem that when a domain starts, seabios failed to online a vCPU.

After investigation, we found that the reason is in kvm-kmod, KVM_APIC_INIT bit in
vcpu->arch.apic->pending_events was overwritten by qemu, and thus an INIT IPI sent
to AP was lost. Qemu does this since libvirtd sends a ‘query-cpus’ qmp command to qemu
on VM start.

In qemu, qmp_query_cpus-> cpu_synchronize_state-> kvm_cpu_synchronize_state->
do_kvm_cpu_synchronize_state, qemu gets registers/vcpu_events from kvm-kmod and
sets cpu->kvm_vcpu_dirty to true, and vcpu thread in qemu will call
kvm_arch_put_registers if cpu->kvm_vcpu_dirty is true, thus pending_events is
overwritten by qemu.

I think there is no need for qemu to set cpu->kvm_vcpu_dirty to true after ‘query-cpus’,
and  kvm-kmod should not clear KVM_APIC_INIT unconditionally. And I am not sure whether
it is OK for qemu to set cpu->kvm_vcpu_dirty in do_kvm_cpu_synchronize_state in each caller.

What’s your opinion?