From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liran Alon Subject: Re: [PATCH v2 1/8] KVM: VMX: No need to clear pending NMI/interrupt on inject realmode interrupt Date: Sat, 02 Dec 2017 02:19:53 +0200 Message-ID: <5A21F1A9.2060805@ORACLE.COM> References: <1511278211-12257-1-git-send-email-liran.alon@oracle.com> <1511278211-12257-2-git-send-email-liran.alon@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , kvm list , Wanpeng Li , Idan Brown , Krish Sadhukhan To: Jim Mattson Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:25217 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414AbdLBAUB (ORCPT ); Fri, 1 Dec 2017 19:20:01 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 02/12/17 01:45, Jim Mattson wrote: > Reviewed-by: Jim Mattson Thanks for the review. > > On Tue, Nov 21, 2017 at 7:30 AM, Liran Alon wrote: >> kvm_inject_realmode_interrupt() is called from one of the injection >> functions which writes event-injection to VMCS: vmx_queue_exception(), >> vmx_inject_irq() and vmx_inject_nmi(). >> >> All these functions are called just to cause an event-injection to >> guest. They are not responsible of manipulating the event-pending >> flag. The only purpose of kvm_inject_realmode_interrupt() should be >> to emulate real-mode interrupt-injection. >> >> This was also incorrect when called from vmx_queue_exception(). >> >> Signed-off-by: Liran Alon >> Reviewed-by: Nikita Leshenko >> Reviewed-by: Krish Sadhukhan >> Signed-off-by: Krish Sadhukhan >> --- >> arch/x86/kvm/x86.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >> index 34c85aa2e2d1..c85fc4406a7d 100644 >> --- a/arch/x86/kvm/x86.c >> +++ b/arch/x86/kvm/x86.c >> @@ -5411,11 +5411,6 @@ int kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip) >> kvm_rip_write(vcpu, ctxt->eip); >> kvm_set_rflags(vcpu, ctxt->eflags); >> >> - if (irq == NMI_VECTOR) >> - vcpu->arch.nmi_pending = 0; >> - else >> - vcpu->arch.interrupt.pending = false; >> - >> return EMULATE_DONE; >> } >> EXPORT_SYMBOL_GPL(kvm_inject_realmode_interrupt); >> -- >> 1.9.1 >>