From: Wei Wang <wei.w.wang@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
cohuck@redhat.com, borntraeger@de.ibm.com, pbonzini@redhat.com,
dgilbert@redhat.com, pasic@linux.ibm.com
Subject: Re: [PATCH v3 2/3] virtio-balloon: improve update_balloon_size_func
Date: Tue, 15 Jan 2019 10:18:59 +0800 [thread overview]
Message-ID: <5C3D4313.7090306@intel.com> (raw)
In-Reply-To: <20190114195450-mutt-send-email-mst@kernel.org>
On 01/15/2019 09:00 AM, Michael S. Tsirkin wrote:
> On Mon, Jan 07, 2019 at 03:01:05PM +0800, Wei Wang wrote:
>> There is no need to update the balloon actual register when there is no
>> ballooning request. This patch avoids update_balloon_size when diff is 0.
>>
>> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> It sounds reasonable but it does have a side effect of
> not writing into actual anymore.
>
> I am not sure actual never can get out of sync as a result.
>
> So better deferred, pls send this in the next merge window.
>
No problem, it's not urgent to me.
Best,
Wei
next prev parent reply other threads:[~2019-01-15 2:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 7:01 [PATCH v3 0/3] virtio-balloon: tweak config_changed Wei Wang
2019-01-07 7:01 ` [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation Wei Wang
2019-01-07 13:44 ` Michael S. Tsirkin
2019-01-07 13:47 ` Michael S. Tsirkin
2019-01-07 13:49 ` Christian Borntraeger
2019-01-08 5:35 ` Wei Wang
2019-01-08 8:46 ` Christian Borntraeger
2019-01-09 10:35 ` Wei Wang
2019-01-09 12:07 ` Christian Borntraeger
2019-01-09 14:52 ` Michael S. Tsirkin
2019-01-09 18:22 ` Christian Borntraeger
2019-01-09 18:31 ` Michael S. Tsirkin
2019-01-09 14:49 ` Michael S. Tsirkin
2019-01-15 0:53 ` Michael S. Tsirkin
2019-01-07 7:01 ` [PATCH v3 2/3] virtio-balloon: improve update_balloon_size_func Wei Wang
2019-01-15 1:00 ` Michael S. Tsirkin
2019-01-15 2:18 ` Wei Wang [this message]
2019-01-07 7:01 ` [PATCH v3 3/3] virtio_balloon: remove the unnecessary 0-initialization Wei Wang
2019-01-07 14:07 ` Cornelia Huck
2019-01-07 13:40 ` [PATCH v3 0/3] virtio-balloon: tweak config_changed Christian Borntraeger
2019-01-07 13:45 ` Michael S. Tsirkin
2019-01-07 13:50 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C3D4313.7090306@intel.com \
--to=wei.w.wang@intel.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox