From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Wang Subject: Re: [PATCH v3 2/3] virtio-balloon: improve update_balloon_size_func Date: Tue, 15 Jan 2019 10:18:59 +0800 Message-ID: <5C3D4313.7090306@intel.com> References: <1546844466-38079-1-git-send-email-wei.w.wang@intel.com> <1546844466-38079-3-git-send-email-wei.w.wang@intel.com> <20190114195450-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, cohuck@redhat.com, borntraeger@de.ibm.com, pbonzini@redhat.com, dgilbert@redhat.com, pasic@linux.ibm.com To: "Michael S. Tsirkin" Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20190114195450-mutt-send-email-mst@kernel.org> List-Id: kvm.vger.kernel.org On 01/15/2019 09:00 AM, Michael S. Tsirkin wrote: > On Mon, Jan 07, 2019 at 03:01:05PM +0800, Wei Wang wrote: >> There is no need to update the balloon actual register when there is no >> ballooning request. This patch avoids update_balloon_size when diff is 0. >> >> Signed-off-by: Wei Wang >> Reviewed-by: Cornelia Huck >> Reviewed-by: Halil Pasic > It sounds reasonable but it does have a side effect of > not writing into actual anymore. > > I am not sure actual never can get out of sync as a result. > > So better deferred, pls send this in the next merge window. > No problem, it's not urgent to me. Best, Wei