From: Adrian Hunter <adrian.hunter@intel.com>
To: <pbonzini@redhat.com>, <seanjc@google.com>
Cc: <mlevitsk@redhat.com>, <kvm@vger.kernel.org>,
<rick.p.edgecombe@intel.com>, <kirill.shutemov@linux.intel.com>,
<kai.huang@intel.com>, <reinette.chatre@intel.com>,
<xiaoyao.li@intel.com>, <tony.lindgren@linux.intel.com>,
<binbin.wu@linux.intel.com>, <isaku.yamahata@intel.com>,
<linux-kernel@vger.kernel.org>, <yan.y.zhao@intel.com>,
<chao.gao@intel.com>
Subject: Re: [PATCH V3 1/1] KVM: TDX: Add sub-ioctl KVM_TDX_TERMINATE_VM
Date: Fri, 6 Jun 2025 17:53:50 +0300 [thread overview]
Message-ID: <5ad4a1c1-e04d-4773-a739-c21b1df41aed@intel.com> (raw)
In-Reply-To: <e5ede906-0dd2-4f41-86e1-1364c8321774@intel.com>
On 11/05/2025 11:57, Adrian Hunter wrote:
> On 25/04/2025 10:57, Adrian Hunter wrote:
>> +static int tdx_terminate_vm(struct kvm *kvm)
>> +{
>> + if (!kvm_trylock_all_vcpus(kvm))
>
> Introduction of kvm_trylock_all_vcpus() is still in progress:
>
> https://lore.kernel.org/r/20250430203013.366479-3-mlevitsk@redhat.com/
>
> but it has kvm_trylock_all_vcpus(kvm) return value the other way around, so
> this will instead need to be:
>
> if (kvm_trylock_all_vcpus(kvm))
>
Sean, do you have any comments on this patch? Should I send out a new version
with the change above?
Note kvm_trylock_all_vcpus() now in Linus' tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e4a454ced74c0ac97c8bd32f086ee3ad74528780
next prev parent reply other threads:[~2025-06-06 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 7:57 [PATCH V3 0/1] KVM: TDX: Decrease TDX VM shutdown time Adrian Hunter
2025-04-25 7:57 ` [PATCH V3 1/1] KVM: TDX: Add sub-ioctl KVM_TDX_TERMINATE_VM Adrian Hunter
2025-05-11 8:57 ` Adrian Hunter
2025-06-06 14:53 ` Adrian Hunter [this message]
2025-06-06 19:17 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ad4a1c1-e04d-4773-a739-c21b1df41aed@intel.com \
--to=adrian.hunter@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tony.lindgren@linux.intel.com \
--cc=xiaoyao.li@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox