From: Michal Luczaj <mhal@rbox.co>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Arseniy Krasnov" <avkrasnov@salutedevices.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] vsock/virtio: Fix data loss/disclosure due to joining of non-linear skb in RX queue
Date: Thu, 8 Jan 2026 10:58:01 +0100 [thread overview]
Message-ID: <5ae4dbd2-52e0-467d-8342-d3dd6d7029ff@rbox.co> (raw)
In-Reply-To: <20260108-vsock-recv-coalescence-v1-0-26f97bb9a99b@rbox.co>
On 1/8/26 10:54, Michal Luczaj wrote:
> Loopback transport coalesces some skbs too eagerly. Handling a zerocopy
> (non-linear) skb as a linear one leads to skb data loss and kernel memory
> disclosure.
>
> Plug the loss/leak by allowing only linear skb join. Provide a test.
Aaand I forgot to set the "net" prefix. Please let me know if I should
resend just for that.
Sorry,
Michal
prev parent reply other threads:[~2026-01-08 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 9:54 [PATCH 0/2] vsock/virtio: Fix data loss/disclosure due to joining of non-linear skb in RX queue Michal Luczaj
2026-01-08 9:54 ` [PATCH 1/2] vsock/virtio: Coalesce only linear skb Michal Luczaj
2026-01-09 16:18 ` Stefano Garzarella
2026-01-11 10:59 ` Michal Luczaj
2026-01-12 14:07 ` Stefano Garzarella
2026-01-08 9:54 ` [PATCH 2/2] vsock/test: Add test for a linear and non-linear skb getting coalesced Michal Luczaj
2026-01-09 16:32 ` Stefano Garzarella
2026-01-11 10:59 ` Michal Luczaj
2026-01-12 13:44 ` Stefano Garzarella
2026-01-12 15:52 ` Michal Luczaj
2026-01-12 16:48 ` Stefano Garzarella
2026-01-12 21:20 ` Michal Luczaj
2026-01-13 9:36 ` Stefano Garzarella
2026-01-13 15:11 ` Michal Luczaj
2026-01-08 9:58 ` Michal Luczaj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ae4dbd2-52e0-467d-8342-d3dd6d7029ff@rbox.co \
--to=mhal@rbox.co \
--cc=avkrasnov@salutedevices.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox