From: Paolo Bonzini <pbonzini@redhat.com>
To: raspl@linux.vnet.ibm.com, kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, frankja@linux.vnet.ibm.com
Subject: Re: [PATCH v2 09/11] tools/kvm_stat: stop ignoring unhandled arguments
Date: Tue, 12 Dec 2017 19:06:33 +0100 [thread overview]
Message-ID: <5e1d9c5e-e120-fe63-2f86-c60f82e372a4@redhat.com> (raw)
In-Reply-To: <6c4b2984-9ab8-8def-17c9-881a9e198bb7@linux.vnet.ibm.com>
On 12/12/2017 19:04, Stefan Raspl wrote:
> On 12.12.2017 16:56, Paolo Bonzini wrote:
>> On 11/12/2017 12:25, Stefan Raspl wrote:
>>> )
>>> - (options, _) = optparser.parse_args(sys.argv)
>>> + options, ukn = optparser.parse_args(sys.argv)
>>> + if len(ukn) != 1:
>>> + sys.exit('Error: Unknown argument(s): ' + ', '.join(ukn[-2:]))
>>
>> I'm replacing this with "unkn". But, why "-2:" instead of "1:"?
>
> Yes, that needs to be a 1: indeed - not sure what I was thinking :O
Fine then. :)
Paolo
next prev parent reply other threads:[~2017-12-12 18:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 11:25 [PATCH v2 00/11] tools/kvm_stat: misc fixes Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 01/11] tools/kvm_stat: fix command line option '-g' Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 02/11] tools/kvm_stat: fix drilldown in events-by-guests mode Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 03/11] tools/kvm_stat: fix missing field update after filter change Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 04/11] tools/kvm_stat: fix extra handling of 'help' with fields filter Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 05/11] tools/kvm_stat: fix child trace events accounting Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 06/11] tools/kvm_stat: add hint on '-f help' to man page Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 07/11] tools/kvm_stat: handle invalid regular expressions Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 08/11] tools/kvm_stat: suppress usage information on command line errors Stefan Raspl
2017-12-12 15:53 ` Paolo Bonzini
2017-12-12 18:09 ` Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 09/11] tools/kvm_stat: stop ignoring unhandled arguments Stefan Raspl
2017-12-12 15:56 ` Paolo Bonzini
2017-12-12 18:04 ` Stefan Raspl
2017-12-12 18:06 ` Paolo Bonzini [this message]
2017-12-11 11:25 ` [PATCH v2 10/11] tools/kvm_stat: sort '-f help' output Stefan Raspl
2017-12-11 12:20 ` Janosch Frank
2017-12-12 11:30 ` Stefan Raspl
2017-12-12 13:59 ` Stefan Raspl
2017-12-12 18:21 ` Stefan Raspl
2017-12-11 11:25 ` [PATCH v2 11/11] tools/kvm_stat: add line for totals Stefan Raspl
2017-12-12 16:00 ` [PATCH v2 00/11] tools/kvm_stat: misc fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e1d9c5e-e120-fe63-2f86-c60f82e372a4@redhat.com \
--to=pbonzini@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=raspl@linux.vnet.ibm.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox