Re: [PATCH v2 2/4] KVM: x86: Move PML page to common vcpu arch structure

["Huang, Kai" <kai.huang@intel.com>]

On Wed, 2025-09-17 at 09:01 +0530, Nikunj A. Dadhania wrote:
> 
> On 9/16/2025 3:57 PM, Huang, Kai wrote:
> > On Mon, 2025-09-15 at 08:59 +0000, Nikunj A Dadhania wrote:
> > > Move the PML page from VMX-specific vcpu_vmx structure to the common
> > > kvm_vcpu_arch structure to share it between VMX and SVM implementations.
> > > 
> > > Update all VMX references accordingly, and simplify the
> > > kvm_flush_pml_buffer() interface by removing the page parameter since it
> > > can now access the page directly from the vcpu structure.
> > > 
> > > No functional change, restructuring to prepare for SVM PML support.
> > > 
> > > Suggested-by: Kai Huang <kai.huang@intel.com>
> > > Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
> > 
> > Nit: IMHO it's also better to explain why we only moved the PML buffer
> > pointer but not the code which allocates/frees the PML buffer:
> > 
> >   Move the PML page to x86 common code only without moving the PML page 
> >   allocation code, since for AMD the PML buffer must be allocated using
> >   snp_safe_alloc_page().
> 
> Ack
> 

Btw, just asking: why not just merging this patch to the first patch?

I don't have strong preference but seems patch 1/2 are connected (they
both move VMX specific code to x86 common for share) and could be one.