public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ryota Ozaki <ozaki.ryota@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Ryota OZAKI <ozaki.ryota@gmail.com>
Subject: Re: nice value is ignored on cpu time accounting of a guest?
Date: Tue, 20 Oct 2009 16:38:59 +0900	[thread overview]
Message-ID: <5e93dcec0910200038k4fa12f8bl819105e56ecfb23d@mail.gmail.com> (raw)
In-Reply-To: <4ADD6812.3050900@redhat.com>

On Tue, Oct 20, 2009 at 4:34 PM, Avi Kivity <avi@redhat.com> wrote:
> On 10/20/2009 04:27 PM, Ryota Ozaki wrote:

>> Well, like this?
>>
>>         /* Add user time to cpustat. */
>>         tmp = cputime_to_cputime64(cputime);
>>         if (TASK_NICE(p)>  0) {
>>                 cpustat->nice = cputime64_add(cpustat->nice, tmp);
>>                 cpustat->guest_nice = cputime64_add(cpustat->guest_nice,
>> tmp);
>>         } else {
>>                 cpustat->user = cputime64_add(cpustat->user, tmp);
>>                 cpustat->guest = cputime64_add(cpustat->guest, tmp);
>>         }
>>
>
> In account_guest_time()?  Yes.

Yes.

OK, I'll send a patch later. Thanks!

  ozaki-r

      reply	other threads:[~2009-10-20  7:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-19  9:46 nice value is ignored on cpu time accounting of a guest? Ryota Ozaki
2009-10-20  5:21 ` Avi Kivity
2009-10-20  7:06   ` Ryota Ozaki
2009-10-20  7:17     ` Avi Kivity
2009-10-20  7:27       ` Ryota Ozaki
2009-10-20  7:34         ` Avi Kivity
2009-10-20  7:38           ` Ryota Ozaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e93dcec0910200038k4fa12f8bl819105e56ecfb23d@mail.gmail.com \
    --to=ozaki.ryota@gmail.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox