From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] kvm: vmx: Raise #UD on unsupported RDSEED
Date: Mon, 21 Aug 2017 18:50:43 +0200
Message-ID: <5f1a65fc-4290-7769-c043-a2da36e8db6b@redhat.com>
References: <20170818184310.117806-1-jmattson@google.com>
 <551fa98c-2898-87a7-5e8b-96f2f463f182@redhat.com>
 <CALMp9eQTZwzSjzuf3sH17oqgLjJjewCpJH_CKzk2rZXcmiv=EQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: kvm list <kvm@vger.kernel.org>
To: Jim Mattson <jmattson@google.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:54624 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753636AbdHUQup (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 21 Aug 2017 12:50:45 -0400
In-Reply-To: <CALMp9eQTZwzSjzuf3sH17oqgLjJjewCpJH_CKzk2rZXcmiv=EQ@mail.gmail.com>
Content-Language: en-US
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 21.08.2017 18:37, Jim Mattson wrote:
> Right. If L1 doesn't support RDSEED, then the corresponding
> "allowed-1" bit in the IA32_VMX_PROCBASED_CTLS2 MSR should be cleared.
> I think vmx_cpuid_update is the right place for this. Note, however,
> that prepare_vmcs02() should still respect L0's setting of this bit.
> 

Right, now I also realize why you sent v2 (EXITING vs. !EXITING) :)


-- 

Thanks,

David