From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH 2/6] KVM: VMX: remove bogus check for invalid EPT violation Date: Wed, 12 Apr 2017 22:00:32 +0200 Message-ID: <60bc8a46-1034-c611-4525-18496fc57bf1@redhat.com> References: <1490867732-16743-1-git-send-email-pbonzini@redhat.com> <1490867732-16743-3-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <1490867732-16743-3-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 30.03.2017 11:55, Paolo Bonzini wrote: > handle_ept_violation is checking for "guest-linear-address invalid" + > "not a paging-structure walk". However, _all_ EPT violations without > a valid guest linear address are paging structure walks, because those > EPT violations happen when loading the guest PDPTEs. > > Therefore, the check can never be true, and even if it were, KVM doesn't > care about the guest linear address; it only uses the guest *physical* > address VMCS field. So, remove the check altogether. > > Signed-off-by: Paolo Bonzini Reviewed-by: David Hildenbrand -- Thanks, David