From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pz+CUiLu" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F31BFF5 for ; Wed, 13 Dec 2023 23:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702538652; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nTrq+3Cdbpt4RVJomfi0QnbN0tB/JIdZpvtKrvEXuC8=; b=Pz+CUiLu1e/N9JR3lEdfrBHxqibJXgGtvpExX0HuUuLCo5dYACWkXV5cnuZF7N4lWVn6Uh NMweK7GbQhOY+AM9KmiKGcUcP4txLLyVte3IJqC8Ljl6l+MYvj5iN7oK6wq3fjOLIUJb7V eCtxgNlBRib2iPGJL7jR1ZuA+VKVryw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-vWNppZLDPwuG1OrnZAutmA-1; Thu, 14 Dec 2023 02:24:10 -0500 X-MC-Unique: vWNppZLDPwuG1OrnZAutmA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40c440f9595so27455585e9.2 for ; Wed, 13 Dec 2023 23:24:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702538649; x=1703143449; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nTrq+3Cdbpt4RVJomfi0QnbN0tB/JIdZpvtKrvEXuC8=; b=mVEoZH3nUwgu15omnuARUqqobM5ots/CQLzuprSycavtxtg2fBCnV0tk1G5lkXBX9C 13qsWcpImqV60b90eRe3xEIbdCLaDRWSvP+9ES269uAoJhkwJbfJ77jR1ClHFWPIdorV XiOorpJU/H8ptvAiNxLtu2LcK16hEOdkkrxuvGYNCltkACrpr38w6DzcVecljtyNc9vs lKZa/Ox21De9dLHSTwhU2HeqrkVbncm6TX6P97QtJqR5RkFfBmTAhwjV/j/8csst+xjH zk1GSPSe+I+VpbIfopqkJmSUglACLgC5qjxZTt84Dwh9ZodBZLTI46v13L1bu1krSDLH uong== X-Gm-Message-State: AOJu0YxvL0rAxWXYj2Jfd7fa6cWyqDlld2D45eEi6eN70hS2xFn73CYz Toaoi/ncfqYCzqCWG0UruCYgp3W9vlC5pr1ZaDTjFirPQh1974K8SYSeKsdR1w7ZYa15UJ7x3/z vz9JexOJtsxjh X-Received: by 2002:a1c:7916:0:b0:40c:55a7:7735 with SMTP id l22-20020a1c7916000000b0040c55a77735mr2016778wme.118.1702538649509; Wed, 13 Dec 2023 23:24:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEP1uSGIJVLfMWqdXKJluitZInxrGncOnNatxqUThqfOfa95Chpt5bRpMkX2rLimEB8pTCrnA== X-Received: by 2002:a1c:7916:0:b0:40c:55a7:7735 with SMTP id l22-20020a1c7916000000b0040c55a77735mr2016754wme.118.1702538649091; Wed, 13 Dec 2023 23:24:09 -0800 (PST) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id gw18-20020a05600c851200b004053e9276easm25685177wmb.32.2023.12.13.23.24.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 23:24:08 -0800 (PST) Message-ID: <6140fc8a-4044-4891-854d-9bf555c5dd78@redhat.com> Date: Thu, 14 Dec 2023 08:24:05 +0100 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: eric.auger@redhat.com Subject: Re: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout Content-Language: en-US To: Cleber Rosa , =?UTF-8?Q?Alex_Benn=C3=A9e?= Cc: qemu-devel@nongnu.org, Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , David Woodhouse References: <20231208190911.102879-1-crosa@redhat.com> <20231208190911.102879-4-crosa@redhat.com> <8734w8fzbc.fsf@draig.linaro.org> <87sf45vpad.fsf@p1.localdomain> From: Eric Auger In-Reply-To: <87sf45vpad.fsf@p1.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Cleber, On 12/13/23 21:08, Cleber Rosa wrote: > Alex Bennée writes: > >> Cleber Rosa writes: >> >>> Based on many runs, the average run time for these 4 tests is around >>> 250 seconds, with 320 seconds being the ceiling. In any way, the >>> default 120 seconds timeout is inappropriate in my experience. >> I would rather see these tests updated to fix: >> >> - Don't use such an old Fedora 31 image > I remember proposing a bump in Fedora version used by default in > avocado_qemu.LinuxTest (which would propagate to tests such as > boot_linux.py and others), but that was not well accepted. I can > definitely work on such a version bump again. > >> - Avoid updating image packages (when will RH stop serving them?) > IIUC the only reason for updating the packages is to test the network > from the guest, and could/should be done another way. > > Eric, could you confirm this? Sorry for the delay. Yes effectively I used the dnf install to stress the viommu. In the past I was able to trigger viommu bugs that way whereas getting an IP @ for the guest was just successful. > >> - The "test" is a fairly basic check of dmesg/sysfs output > Maybe the network is also an implicit check here. Let's see what Eric > has to say. To be honest I do not remember how avocado does the check in itself; my guess if that if the dnf install does not complete you get a timeout and the test fails. But you may be more knowledged on this than me ;-) Thanks Eric > >> I think building a buildroot image with the tools pre-installed (with >> perhaps more testing) would be a better use of our limited test time. >> >> FWIW the runtime on my machine is: >> >> ➜ env QEMU_TEST_FLAKY_TESTS=1 ./pyvenv/bin/avocado run ./tests/avocado/intel_iommu.py >> JOB ID : 5c582ccf274f3aee279c2208f969a7af8ceb9943 >> JOB LOG : /home/alex/avocado/job-results/job-2023-12-11T16.53-5c582cc/job.log >> (1/4) ./tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu: PASS (44.21 s) >> (2/4) ./tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu_strict: PASS (78.60 s) >> (3/4) ./tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu_strict_cm: PASS (65.57 s) >> (4/4) ./tests/avocado/intel_iommu.py:IntelIOMMU.test_intel_iommu_pt: PASS (66.63 s) >> RESULTS : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0 >> JOB TIME : 255.43 s >> > Yes, I've also seen similar runtimes in other environments... so it > looks like it depends a lot on the "dnf -y install numactl-devel". If > that can be removed, the tests would have much more predictable runtimes. >