From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Aneesh Kumar K.V (Arm)" <aneesh.kumar@kernel.org>,
linux-coco@lists.linux.dev
Cc: baolu.lu@linux.intel.com, Alex Williamson <alex@shazbot.org>,
Alexey Kardashevskiy <aik@amd.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Jacob Pan <jacob.pan@linux.microsoft.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Joerg Roedel <joro@8bytes.org>,
Jonathan Cameron <jic23@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>,
Krishna Reddy <vdumpa@nvidia.com>, Lukas Wunner <lukas@wunner.de>,
Nicolin Chen <nicolinc@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
Samuel Ortiz <sameo@rivosinc.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Steven Price <steven.price@arm.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Thierry Reding <thierry.reding@kernel.org>,
Vasant Hegde <vasant.hegde@amd.com>,
Will Deacon <will@kernel.org>,
Xu Yilun <yilun.xu@linux.intel.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
iommu@lists.linux.dev,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
patches@lists.linux.dev
Subject: Re: [PATCH v9 11/13] iommufd/viommu: Allow vIOMMUs without a parent HWPT
Date: Fri, 20 Nov 2026 14:49:56 +0800 [thread overview]
Message-ID: <620712ae-e21e-4daa-9cd3-0c5d06ffb67f@linux.intel.com> (raw)
In-Reply-To: <20261116081935.85372-12-aneesh.kumar@kernel.org>
On 11/16/2026 4:19 PM, Aneesh Kumar K.V (Arm) wrote:
> VIOMMU_ALLOC currently requires a nesting parent HWPT_PAGING even when
> the selected vIOMMU implementation has no use for one. This would force
> implementations such as the following Arm Realm vIOMMU to create an
> unused parent.
>
> Add IOMMUFD_VIOMMU_NO_HWPT so an implementation can opt out. Require
> hwpt_id to be zero in that case and pass a NULL parent domain to its
> initialization callback. For implementations that require a HWPT, verify
> that the parent supports nesting and its domain belongs to the device's
> physical IOMMU driver before invoking viommu_init().
>
> Reject nested domain and hardware queue allocation for a vIOMMU without
> a parent, and document the two allocation modes in the UAPI.
>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Kevin Tian <kevin.tian@intel.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: iommu@lists.linux.dev
> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>
> ---
> Documentation/userspace-api/iommufd.rst | 44 +++++++++---------
> drivers/iommu/iommufd/hw_pagetable.c | 14 ++++--
> drivers/iommu/iommufd/viommu.c | 62 +++++++++++++++----------
> include/linux/iommufd.h | 13 ++++--
> include/uapi/linux/iommufd.h | 3 +-
> 5 files changed, 81 insertions(+), 55 deletions(-)
>
[...]
> diff --git a/drivers/iommu/iommufd/hw_pagetable.c b/drivers/iommu/iommufd/hw_pagetable.c
> index ae62db50885c..52e52ef089a2 100644
> --- a/drivers/iommu/iommufd/hw_pagetable.c
> +++ b/drivers/iommu/iommufd/hw_pagetable.c
> @@ -306,6 +306,10 @@ iommufd_viommu_alloc_hwpt_nested(struct iommufd_viommu *viommu, u32 flags,
> return ERR_PTR(-EOPNOTSUPP);
> if (!user_data->len)
> return ERR_PTR(-EOPNOTSUPP);
> + if (!viommu->hwpt)
> + return ERR_PTR(-EOPNOTSUPP);
> + if (!viommu->iommu_dev)
> + return ERR_PTR(-EOPNOTSUPP);
> if (!viommu->ops || !viommu->ops->alloc_domain_nested)
> return ERR_PTR(-EOPNOTSUPP);
>
> @@ -404,10 +408,12 @@ int iommufd_hwpt_alloc(struct iommufd_ucmd *ucmd)
> struct iommufd_viommu *viommu;
>
> viommu = container_of(pt_obj, struct iommufd_viommu, obj);
> - iommu_dev = iommufd_device_get_iommu_dev(idev);
> - if (!iommu_dev || viommu->iommu_dev != iommu_dev) {
> - rc = -EINVAL;
> - goto out_unlock;
> + if (viommu->iommu_dev) {
> + iommu_dev = iommufd_device_get_iommu_dev(idev);
> + if (!iommu_dev || viommu->iommu_dev != iommu_dev) {
> + rc = -EINVAL;
> + goto out_unlock;
> + }
Is it intended that every tsm-provided viommu has viommu->iommu_dev ==
NULL?
If so, could the tsm-provider patch make provider selection exclusive by
looking up the physical iommu only on the fallback path? All checks
against viommu->iommu_dev should be in that patch. This non-parent-hwpt
viommu support patch should no longer check viommu->iommu_dev.
Also, if viommu->iommu_dev and viommu->tsm_dev are mutually exclusive,
could that be made explicit in a comment or by using a tagged union?
> }
> hwpt_nested = iommufd_viommu_alloc_hwpt_nested(
> viommu, cmd->flags, &user_data);
> diff --git a/drivers/iommu/iommufd/viommu.c b/drivers/iommu/iommufd/viommu.c
> index 7e74d3992ae4..cadd8a5ca912 100644
> --- a/drivers/iommu/iommufd/viommu.c
> +++ b/drivers/iommu/iommufd/viommu.c
> @@ -17,7 +17,8 @@ void iommufd_viommu_destroy(struct iommufd_object *obj)
> viommu->ops->destroy(viommu);
> if (viommu->tsm_dev)
> tsm_put_device(viommu->tsm_dev);
> - refcount_dec(&viommu->hwpt->common.obj.users);
> + if (viommu->hwpt)
> + refcount_dec(&viommu->hwpt->common.obj.users);
> if (viommu->kvm_file)
> fput(viommu->kvm_file);
> xa_destroy(&viommu->vdevs);
> @@ -31,11 +32,11 @@ int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd)
> .uptr = u64_to_user_ptr(cmd->data_uptr),
> .len = cmd->data_len,
> };
> - struct iommufd_hwpt_paging *hwpt_paging;
> + struct iommufd_hwpt_paging *hwpt_paging = NULL;
> struct tsm_dev *tsm_dev = NULL;
> struct iommufd_viommu *viommu;
> struct iommufd_device *idev;
> - struct iommu_device *iommu_dev;
> + struct iommu_device *iommu_dev = NULL;
> const struct iommufd_viommu_ops *ops;
> size_t viommu_size;
> int rc;
> @@ -47,11 +48,6 @@ int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd)
> if (IS_ERR(idev))
> return PTR_ERR(idev);
>
> - iommu_dev = iommufd_device_get_iommu_dev(idev);
> - if (!iommu_dev) {
> - rc = -EOPNOTSUPP;
> - goto out_put_idev;
> - }
> tsm_dev = tsm_get_device(idev->dev);
> if (IS_ERR(tsm_dev)) {
> rc = PTR_ERR(tsm_dev);
> @@ -68,6 +64,11 @@ int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd)
> tsm_put_device(tsm_dev);
> tsm_dev = NULL;
> }
> + iommu_dev = iommufd_device_get_iommu_dev(idev);
> + if (!iommu_dev) {
> + rc = -EOPNOTSUPP;
> + goto out_put_idev;
> + }
> if (!iommu_dev->ops->get_viommu_ops) {
> rc = -EOPNOTSUPP;
> goto out_put_idev;
> @@ -93,15 +94,22 @@ int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd)
> goto out_put_idev;
> }
>
> - hwpt_paging = iommufd_get_hwpt_paging(ucmd, cmd->hwpt_id);
> - if (IS_ERR(hwpt_paging)) {
> - rc = PTR_ERR(hwpt_paging);
> - goto out_put_idev;
> - }
> -
> - if (!hwpt_paging->nest_parent) {
> - rc = -EINVAL;
> - goto out_put_hwpt;
> + if (ops->flags & IOMMUFD_VIOMMU_NO_HWPT) {
> + if (cmd->hwpt_id) {
> + rc = -EINVAL;
> + goto out_put_idev;
> + }
> + } else {
> + hwpt_paging = iommufd_get_hwpt_paging(ucmd, cmd->hwpt_id);
> + if (IS_ERR(hwpt_paging)) {
> + rc = PTR_ERR(hwpt_paging);
> + goto out_put_idev;
> + }
> + if (!hwpt_paging->nest_parent || !iommu_dev ||
> + hwpt_paging->common.domain->owner != iommu_dev->ops) {
> + rc = -EINVAL;
> + goto out_put_hwpt;
> + }
> }
>
> viommu = (struct iommufd_viommu *)_iommufd_object_alloc_ucmd(
> @@ -119,7 +127,8 @@ int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd)
> viommu->tsm_dev = tsm_dev;
> tsm_dev = NULL;
> viommu->hwpt = hwpt_paging;
> - refcount_inc(&viommu->hwpt->common.obj.users);
> + if (viommu->hwpt)
> + refcount_inc(&viommu->hwpt->common.obj.users);
> INIT_LIST_HEAD(&viommu->veventqs);
> init_rwsem(&viommu->veventqs_rwsem);
> /*
> @@ -130,7 +139,7 @@ int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd)
> viommu->iommu_dev = iommu_dev;
>
> rc = ops->viommu_init(viommu, idev->dev,
> - hwpt_paging->common.domain,
> + hwpt_paging ? hwpt_paging->common.domain : NULL,
> user_data.len ? &user_data : NULL);
> if (rc)
> goto out_put_hwpt;
> @@ -140,7 +149,8 @@ int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd)
> rc = iommufd_ucmd_respond(ucmd, sizeof(*cmd));
>
> out_put_hwpt:
> - iommufd_put_object(ucmd->ictx, &hwpt_paging->common.obj);
> + if (hwpt_paging)
> + iommufd_put_object(ucmd->ictx, &hwpt_paging->common.obj);
> out_put_idev:
> if (tsm_dev)
> tsm_put_device(tsm_dev);
> @@ -240,10 +250,12 @@ int iommufd_vdevice_alloc_ioctl(struct iommufd_ucmd *ucmd)
> goto out_put_idev;
> }
>
> - iommu_dev = iommufd_device_get_iommu_dev(idev);
> - if (!iommu_dev || viommu->iommu_dev != iommu_dev) {
> - rc = -EINVAL;
> - goto out_put_idev;
> + if (viommu->iommu_dev) {
> + iommu_dev = iommufd_device_get_iommu_dev(idev);
> + if (!iommu_dev || viommu->iommu_dev != iommu_dev) {
> + rc = -EINVAL;
> + goto out_put_idev;
> + }
> }
>
> mutex_lock(&idev->igroup->lock);
> @@ -463,7 +475,7 @@ int iommufd_hw_queue_alloc_ioctl(struct iommufd_ucmd *ucmd)
> if (IS_ERR(viommu))
> return PTR_ERR(viommu);
>
> - if (!viommu->ops || !viommu->ops->get_hw_queue_size ||
> + if (!viommu->hwpt || !viommu->ops || !viommu->ops->get_hw_queue_size ||
> !viommu->ops->hw_queue_init_phys) {
> rc = -EOPNOTSUPP;
> goto out_put_viommu;
> diff --git a/include/linux/iommufd.h b/include/linux/iommufd.h
> index a4b29915d0ca..4d5995956cce 100644
> --- a/include/linux/iommufd.h
> +++ b/include/linux/iommufd.h
> @@ -6,6 +6,7 @@
> #ifndef __LINUX_IOMMUFD_H
> #define __LINUX_IOMMUFD_H
>
> +#include <linux/bits.h>
> #include <linux/err.h>
> #include <linux/errno.h>
> #include <linux/iommu.h>
> @@ -102,6 +103,7 @@ void iommufd_ctx_get(struct iommufd_ctx *ictx);
> struct iommufd_viommu {
> struct iommufd_object obj;
> struct iommufd_ctx *ictx;
> + /* Physical IOMMU backing, or NULL. */
> struct iommu_device *iommu_dev;
> struct iommufd_hwpt_paging *hwpt;
> struct file *kvm_file;
[...]
Thanks,
baolu
next prev parent reply other threads:[~2026-11-20 6:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 8:19 [PATCH v9 00/13] iommufd: TSM-backed virtual IOMMUs for confidential guests Aneesh Kumar K.V (Arm)
2026-11-16 8:19 ` [PATCH v9 01/13] virt: coco: tsm: Require PCI operations when registering a TSM Aneesh Kumar K.V (Arm)
2026-11-19 7:18 ` Baolu Lu
2026-11-16 8:19 ` [PATCH v9 02/13] virt: coco: tsm: Remove the device from lookup before PCI teardown Aneesh Kumar K.V (Arm)
2026-11-18 6:43 ` Xu Yilun
2026-11-16 8:19 ` [PATCH v9 03/13] virt: coco: tsm: Complete PCI registration before publishing the device Aneesh Kumar K.V (Arm)
2026-11-18 7:11 ` Xu Yilun
2026-11-16 8:19 ` [PATCH v9 04/13] iommufd/device: Associate KVM file pointer with iommufd_device Aneesh Kumar K.V (Arm)
2026-11-19 8:13 ` Baolu Lu
2026-11-16 8:19 ` [PATCH v9 05/13] iommufd/viommu: Keep a reference to the KVM file Aneesh Kumar K.V (Arm)
2026-11-19 8:20 ` Baolu Lu
2026-11-16 8:19 ` [PATCH v9 06/13] iommufd: Add a vDEVICE operation ioctl framework Aneesh Kumar K.V (Arm)
2026-11-20 1:17 ` Baolu Lu
2026-11-16 8:19 ` [PATCH v9 07/13] PCI/TSM: Remove the legacy guest request interface Aneesh Kumar K.V (Arm)
2026-11-20 1:37 ` Baolu Lu
2026-11-16 8:19 ` [PATCH v9 08/13] PCI/TSM: Keep connections active while device contexts exist Aneesh Kumar K.V (Arm)
2026-11-20 2:58 ` Baolu Lu
2026-11-16 8:19 ` [PATCH v9 09/13] iommufd/viommu: Select vIOMMU operations before allocation Aneesh Kumar K.V (Arm)
2026-11-20 4:44 ` Baolu Lu
2026-11-16 8:19 ` [PATCH v9 10/13] iommufd/viommu: Allow PCI TSM backends to provide vIOMMU operations Aneesh Kumar K.V (Arm)
2026-11-19 19:50 ` Jacob Pan
2026-11-20 5:39 ` Baolu Lu
2026-11-16 8:19 ` [PATCH v9 11/13] iommufd/viommu: Allow vIOMMUs without a parent HWPT Aneesh Kumar K.V (Arm)
2026-11-20 6:49 ` Baolu Lu [this message]
2026-11-16 8:19 ` [PATCH v9 12/13] PCI/TSM: Wait for device contexts before removing a DSM Aneesh Kumar K.V (Arm)
2026-11-16 8:19 ` [PATCH v9 13/13] PCI/TSM: Wait for users during unregister Aneesh Kumar K.V (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=620712ae-e21e-4daa-9cd3-0c5d06ffb67f@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=aik@amd.com \
--cc=alex@shazbot.org \
--cc=aneesh.kumar@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=herbert@gondor.apana.org.au \
--cc=iommu@lists.linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=jgg@ziepe.ca \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=nicolinc@nvidia.com \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=sameo@rivosinc.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=steven.price@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=suzuki.poulose@arm.com \
--cc=thierry.reding@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=vasant.hegde@amd.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox