From: Paolo Bonzini <pbonzini@redhat.com>
To: Roman Kagan <rkagan@virtuozzo.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
peterhornyack@google.com, rkrcmar@redhat.com, den@openvz.org
Subject: Re: [PATCH 3/4] KVM: x86: introduce get_kvmclock_ns
Date: Fri, 2 Sep 2016 18:57:10 +0200 [thread overview]
Message-ID: <6207edf3-72e7-229d-8ff7-a91c23e40cd7@redhat.com> (raw)
In-Reply-To: <20160902165551.2owvzs4peerwtlpd@rkaganb.sw.ru>
On 02/09/2016 18:55, Roman Kagan wrote:
>> > I'll change patch 4 to store the parameters and use them when accessing
>> > the time reference counter MSR. I'll still keep the procedure that goes
>> > through kvmclock. It's a bit more involved for the scale, but
>> > vcpu->last_guest_tsc only provides a part of the offset computation; the
>> > other half is vcpu->hv_clock.system_time and it's not stored anywhere.
> Erm... It is stored right there, in vcpu->hv_clock.system_time, you can
> access it just fine when you populate tsc_ref_page values. Am I missing
> anything?
No. It's not stored anywhere outside vcpu->hv_clock. My reasoning goes
that if I have to use vcpu->hv_clock.system_time I might as well use
vcpu->hv_clock for everything. :)
Paolo
next prev parent reply other threads:[~2016-09-02 16:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 15:26 [PATCH 0/4] KVM: x86: kvmclock cleanups for Hyper-V TSC page Paolo Bonzini
2016-09-01 15:26 ` [PATCH 1/4] KVM: x86: always fill in vcpu->arch.hv_clock Paolo Bonzini
2016-09-02 13:31 ` Roman Kagan
2016-09-02 13:48 ` Paolo Bonzini
2016-09-01 15:26 ` [PATCH 2/4] KVM: x86: initialize kvmclock_offset Paolo Bonzini
2016-09-02 13:32 ` Roman Kagan
2016-09-01 15:26 ` [PATCH 3/4] KVM: x86: introduce get_kvmclock_ns Paolo Bonzini
2016-09-02 13:52 ` Roman Kagan
2016-09-02 14:09 ` Paolo Bonzini
2016-09-02 14:51 ` Roman Kagan
2016-09-02 16:37 ` Paolo Bonzini
2016-09-02 16:55 ` Roman Kagan
2016-09-02 16:57 ` Paolo Bonzini [this message]
2016-09-02 17:07 ` Roman Kagan
2016-09-02 15:24 ` Roman Kagan
2016-09-05 13:59 ` Paolo Bonzini
2016-09-01 15:26 ` [PATCH 4/4] KVM: x86: Hyper-V tsc page setup Paolo Bonzini
2016-09-02 14:17 ` Roman Kagan
-- strict thread matches above, loose matches on Subject: below --
2016-09-19 11:39 [PATCH v2 0/4] KVM: x86: kvmclock cleanups for Hyper-V TSC page Paolo Bonzini
2016-09-19 11:39 ` [PATCH 3/4] KVM: x86: introduce get_kvmclock_ns Paolo Bonzini
2016-09-19 16:33 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6207edf3-72e7-229d-8ff7-a91c23e40cd7@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@openvz.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhornyack@google.com \
--cc=rkagan@virtuozzo.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).