From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 3/4] KVM: x86: introduce get_kvmclock_ns Date: Fri, 2 Sep 2016 18:57:10 +0200 Message-ID: <6207edf3-72e7-229d-8ff7-a91c23e40cd7@redhat.com> References: <1472743575-123756-1-git-send-email-pbonzini@redhat.com> <1472743575-123756-4-git-send-email-pbonzini@redhat.com> <20160902135225.3ynmrv564rbgaca6@rkaganb.sw.ru> <20160902145123.v53bthe64qvj7ris@rkaganb.sw.ru> <9a02e696-f9ac-8caa-5acd-d820374e6773@redhat.com> <20160902165551.2owvzs4peerwtlpd@rkaganb.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Roman Kagan , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, peterhornyack@google.com, rkrcmar@redhat.com, den@openvz.org Return-path: In-Reply-To: <20160902165551.2owvzs4peerwtlpd@rkaganb.sw.ru> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 02/09/2016 18:55, Roman Kagan wrote: >> > I'll change patch 4 to store the parameters and use them when accessing >> > the time reference counter MSR. I'll still keep the procedure that goes >> > through kvmclock. It's a bit more involved for the scale, but >> > vcpu->last_guest_tsc only provides a part of the offset computation; the >> > other half is vcpu->hv_clock.system_time and it's not stored anywhere. > Erm... It is stored right there, in vcpu->hv_clock.system_time, you can > access it just fine when you populate tsc_ref_page values. Am I missing > anything? No. It's not stored anywhere outside vcpu->hv_clock. My reasoning goes that if I have to use vcpu->hv_clock.system_time I might as well use vcpu->hv_clock for everything. :) Paolo