public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, borntraeger@de.ibm.com,
	gor@linux.ibm.com, imbrenda@linux.ibm.com, kvm@vger.kernel.org,
	david@redhat.com, cohuck@redhat.com, thuth@redhat.com
Subject: Re: [PATCH v3] s390x: Add 3f program exception handler
Date: Tue, 8 Sep 2020 15:09:23 +0200	[thread overview]
Message-ID: <6551fde1-e19c-3b97-7a53-5a4dcb97f7bc@linux.ibm.com> (raw)
In-Reply-To: <20200908130655.GF14136@osiris>


[-- Attachment #1.1: Type: text/plain, Size: 1349 bytes --]

On 9/8/20 3:06 PM, Heiko Carstens wrote:
> On Tue, Sep 08, 2020 at 09:05:04AM -0400, Janosch Frank wrote:
>> Program exception 3f (secure storage violation) can only be detected
>> when the CPU is running in SIE with a format 4 state description,
>> e.g. running a protected guest. Because of this and because user
>> space partly controls the guest memory mapping and can trigger this
>> exception, we want to send a SIGSEGV to the process running the guest
>> and not panic the kernel.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> CC: <stable@vger.kernel.org> # 5.7+
>> Fixes: 084ea4d611a3 ("s390/mm: add (non)secure page access exceptions handlers")
>> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>  arch/s390/kernel/entry.h     |  1 +
>>  arch/s390/kernel/pgm_check.S |  2 +-
>>  arch/s390/mm/fault.c         | 20 ++++++++++++++++++++
>>  3 files changed, 22 insertions(+), 1 deletion(-)
> 
> I guess this should go upstream via the s390 tree?

Christian asked the exact same question.
I think we picked the secure/non-secure exception handlers via the s390
tree so bringing these in via s390 would be in line with that.

> Should I pick this up?

That would be nice


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-09-08 19:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 12:46 [PATCH v2 0/2] s390x: pv: Fixes and improvements Janosch Frank
2020-09-07 12:46 ` [PATCH v2 1/2] s390x: uv: Add destroy page call Janosch Frank
2020-09-07 17:59   ` Thomas Huth
2020-09-08  6:28   ` Cornelia Huck
2020-09-07 12:47 ` [PATCH v2 2/2] s390x: Add 3f program exception handler Janosch Frank
2020-09-08  6:39   ` Cornelia Huck
     [not found]   ` <202009080542.UHmgfE5u%lkp@intel.com>
2020-09-08  7:53     ` Heiko Carstens
2020-09-08 13:05       ` [PATCH v3] " Janosch Frank
2020-09-08 13:06         ` Heiko Carstens
2020-09-08 13:09           ` Janosch Frank [this message]
2020-09-08 13:18             ` Heiko Carstens
2020-09-08 13:10           ` Christian Borntraeger
2020-09-08  7:58   ` [PATCH v2 2/2] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6551fde1-e19c-3b97-7a53-5a4dcb97f7bc@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox