From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB91C433E0 for ; Mon, 1 Mar 2021 15:33:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF9F064DD2 for ; Mon, 1 Mar 2021 15:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237242AbhCAPcy (ORCPT ); Mon, 1 Mar 2021 10:32:54 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:14902 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237289AbhCAPct (ORCPT ); Mon, 1 Mar 2021 10:32:49 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 121FTWCm088389 for ; Mon, 1 Mar 2021 10:32:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=to : cc : references : from : subject : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=mS6M51L2K6lkd0qMNVGTgtNUpy7NdWwjUvY3rAXCtJc=; b=mtrab8wo6igdZSl3FFK7mOG+YGvsbd0X+POP/yTLUOI4b+aAqANQv7fTkWs1gqQ9/GdD jbRVx7hQTHNLqc/EvS1jgBpBdCrQw0TGSxk78vqyNuMFa8y+w6wotMhXSWpvTHYelOcU ECHTx+L0/l+yVkO/RR2XFFZB2Ff5F9Auiu+JuNZ66gVPqwNn6rk6iexwGwBHOBoeekkh xRLZXC+Pf+q7gdeWWubkytyis6OH6TtriyVpGeYx/iNOUihKSmo5/75vhD9Qpzpx8C7e GV44wbWobsLybk8aqzmawnD8WJcufxMHKsczFgCRVq0hkRLXLBDJS6MU5UtSH5VxK2Iz gA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 37106d6j13-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 01 Mar 2021 10:32:08 -0500 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 121FU46J093969 for ; Mon, 1 Mar 2021 10:32:07 -0500 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 37106d6hyh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Mar 2021 10:32:07 -0500 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 121FRiLf006730; Mon, 1 Mar 2021 15:32:05 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03ams.nl.ibm.com with ESMTP id 371162g1v8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Mar 2021 15:32:05 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 121FVm5t33030546 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 1 Mar 2021 15:31:48 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2203352057; Mon, 1 Mar 2021 15:32:02 +0000 (GMT) Received: from linux.fritz.box (unknown [9.145.190.79]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id BCA395206D; Mon, 1 Mar 2021 15:32:01 +0000 (GMT) To: Pierre Morel , kvm@vger.kernel.org Cc: david@redhat.com, thuth@redhat.com, cohuck@redhat.com, imbrenda@linux.ibm.com References: <1614599225-17734-1-git-send-email-pmorel@linux.ibm.com> <1614599225-17734-5-git-send-email-pmorel@linux.ibm.com> From: Janosch Frank Subject: Re: [kvm-unit-tests PATCH v4 4/6] s390x: css: implementing Set CHannel Monitor Message-ID: <65d91b9d-861a-bc37-6dcf-418ff05dc7ff@linux.ibm.com> Date: Mon, 1 Mar 2021 16:32:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <1614599225-17734-5-git-send-email-pmorel@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-01_11:2021-03-01,2021-03-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 clxscore=1015 bulkscore=0 mlxscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103010128 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 3/1/21 12:47 PM, Pierre Morel wrote: > We implement the call of the Set CHannel Monitor instruction, > starting the monitoring of the all Channel Sub System, and > initializing channel subsystem monitoring. > > Initial tests report the presence of the extended measurement block > feature, and verify the error reporting of the hypervisor for SCHM. Acked-by: Janosch Frank > > Signed-off-by: Pierre Morel > Reviewed-by: Cornelia Huck > --- > lib/s390x/css.h | 12 ++++++++++++ > s390x/css.c | 35 +++++++++++++++++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/lib/s390x/css.h b/lib/s390x/css.h > index 1cb3de2..b8ac363 100644 > --- a/lib/s390x/css.h > +++ b/lib/s390x/css.h > @@ -310,6 +310,7 @@ struct chsc_scsc { > uint32_t res_04[2]; > struct chsc_header res; > uint32_t res_fmt; > +#define CSSC_EXTENDED_MEASUREMENT_BLOCK 48 > uint64_t general_char[255]; > uint64_t chsc_char[254]; > }; > @@ -360,6 +361,17 @@ bool chsc(void *p, uint16_t code, uint16_t len); > #define css_general_feature(bit) test_bit_inv(bit, chsc_scsc->general_char) > #define css_chsc_feature(bit) test_bit_inv(bit, chsc_scsc->chsc_char) css_test_general_feature(bit) css_test_chsc_feature(bit) ? > > +#define SCHM_DCTM 1 /* activate Device Connection TiMe */ > +#define SCHM_MBU 2 /* activate Measurement Block Update */ > + > +static inline void schm(void *mbo, unsigned int flags) > +{ > + register void *__gpr2 asm("2") = mbo; > + register long __gpr1 asm("1") = flags; > + > + asm("schm" : : "d" (__gpr2), "d" (__gpr1)); > +} > + > bool css_enable_mb(int sid, uint64_t mb, uint16_t mbi, uint16_t flg, bool fmt1); > bool css_disable_mb(int schid); > > diff --git a/s390x/css.c b/s390x/css.c > index c9e4903..e8f96f3 100644 > --- a/s390x/css.c > +++ b/s390x/css.c > @@ -150,6 +150,40 @@ static void css_init(void) > report(1, "CSS initialized"); > } > > +static void test_schm(void) > +{ > + if (css_general_feature(CSSC_EXTENDED_MEASUREMENT_BLOCK)) > + report_info("Extended measurement block available"); > + > + /* bits 59-63 of MB address must be 0 if MBU is defined */ > + report_prefix_push("Unaligned operand"); > + expect_pgm_int(); > + schm((void *)0x01, SCHM_MBU); > + check_pgm_int_code(PGM_INT_CODE_OPERAND); > + report_prefix_pop(); > + > + /* bits 36-61 of register 1 (flags) must be 0 */ > + report_prefix_push("Bad flags"); > + expect_pgm_int(); > + schm(NULL, 0xfffffffc); > + check_pgm_int_code(PGM_INT_CODE_OPERAND); > + report_prefix_pop(); > + > + /* SCHM is a privilege operation */ > + report_prefix_push("Privilege"); > + enter_pstate(); > + expect_pgm_int(); > + schm(NULL, SCHM_MBU); > + check_pgm_int_code(PGM_INT_CODE_PRIVILEGED_OPERATION); > + report_prefix_pop(); > + > + /* Normal operation */ > + report_prefix_push("Normal operation"); > + schm(NULL, SCHM_MBU); > + report(1, "SCHM call without address"); > + report_prefix_pop(); > +} > + > static struct { > const char *name; > void (*func)(void); > @@ -159,6 +193,7 @@ static struct { > { "enumerate (stsch)", test_enumerate }, > { "enable (msch)", test_enable }, > { "sense (ssch/tsch)", test_sense }, > + { "measurement block (schm)", test_schm }, > { NULL, NULL } > }; > >