From: Thomas Huth <thuth@redhat.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Halil Pasic <pasic@linux.vnet.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH] drivers/s390/virtio: Remove the old KVM virtio transport
Date: Wed, 27 Sep 2017 15:06:55 +0200 [thread overview]
Message-ID: <66822fa4-f7fe-565a-bc51-9fe1493378f9@redhat.com> (raw)
In-Reply-To: <20170927125530.GE4032@osiris>
On 27.09.2017 14:55, Heiko Carstens wrote:
> On Wed, Sep 27, 2017 at 01:42:01PM +0200, Thomas Huth wrote:
>> diff --git a/drivers/s390/virtio/Makefile b/drivers/s390/virtio/Makefile
>> index df40692..d9942e0 100644
>> --- a/drivers/s390/virtio/Makefile
>> +++ b/drivers/s390/virtio/Makefile
>> @@ -7,7 +7,4 @@
>> # as published by the Free Software Foundation.
>>
>> s390-virtio-objs := virtio_ccw.o
>> -ifdef CONFIG_S390_GUEST_OLD_TRANSPORT
>> -s390-virtio-objs += kvm_virtio.o
>> -endif
>> obj-$(CONFIG_S390_GUEST) += $(s390-virtio-objs)
>
> Would you mind to simplify the Makefile to just the single line
>
> obj-$(CONFIG_S390_GUEST) += virtio_ccw.o
>
> while you are touching it anyway?
Sure ... I'll send a v2 ... or do you rather want to fix it when picking
up the patch?
Thomas
next prev parent reply other threads:[~2017-09-27 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 11:42 [PATCH] drivers/s390/virtio: Remove the old KVM virtio transport Thomas Huth
2017-09-27 12:55 ` Heiko Carstens
2017-09-27 13:06 ` Thomas Huth [this message]
2017-09-27 14:10 ` Heiko Carstens
2017-09-27 13:03 ` Cornelia Huck
2017-09-27 14:35 ` Halil Pasic
2017-09-28 15:01 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66822fa4-f7fe-565a-bc51-9fe1493378f9@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox