public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: <dan.j.williams@intel.com>
To: Sean Christopherson <seanjc@google.com>, <dan.j.williams@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Kai Huang <kai.huang@intel.com>,
	Xiaoyao Li <xiaoyao.li@intel.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>
Subject: Re: [PATCH] KVM: VMX: Inject #UD if guest tries to execute SEAMCALL or TDCALL
Date: Wed, 15 Oct 2025 08:49:00 -0700	[thread overview]
Message-ID: <68efc26c792a3_19928100a8@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <aO-oIRBhSIZo9mef@google.com>

Sean Christopherson wrote:
[..]
> IMO, any reasonable reading of "inSEAM" is that it is talking about #1, in which
> case the pseudocode effectively says that SEAMCALL should #UD if executed in
> "SEAM VMX non-root operation", but that's obviously not the case based on the
> statement below as well as the TDX-Module code.
> 
> Furthermore, the only transitions for"inSEAM" are that it's set to '1' by SEAMCALL,
> and cleared to '0' by SEAMRET.  That implies that it's _not_ cleared by VM-Enter
> from SEAM VMX root operation to SEAM VMX non-root operation, which reinforces my
> reading of "inSEAM == SEAM operation".

Ah, got it, I see it now. Added this need for clarification to the
errata ticket, and already got an ack on your Note2.

  reply	other threads:[~2025-10-15 15:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 23:10 [PATCH] KVM: VMX: Inject #UD if guest tries to execute SEAMCALL or TDCALL Sean Christopherson
2025-10-15  0:22 ` dan.j.williams
2025-10-15 13:56   ` Sean Christopherson
2025-10-15 15:49     ` dan.j.williams [this message]
2025-10-15  1:13 ` Chao Gao
2025-10-15  3:11   ` Xiaoyao Li
2025-10-15 13:20     ` Sean Christopherson
2025-10-15 10:36 ` Xiaoyao Li
2025-10-15 13:57   ` Sean Christopherson
2025-10-15 14:45     ` Xiaoyao Li
2025-10-16 18:28       ` Sean Christopherson
2025-10-15 13:38 ` Binbin Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68efc26c792a3_19928100a8@dwillia2-mobl4.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=seanjc@google.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox