Re: [PATCH v12 15/23] KVM: selftests: Call TDX init when creating a new TDX vm

Ira Weiny
2025-10-30T22:18:28Z

Sagi Shahar wrote:
> TDX VMs need to issue the KVM_TDX_INIT_VM ioctl after VM creation to
> initialize the TD. This ioctl also sets the cpuids and attributes for
> the VM.
>
> At this point we can also set the common boot parameters such as CR3,

Avoid 'we'.

> CR4, etc. These parameters will get copied to the relevant registers by
> the TD boot code trampoline.
>
> Signed-off-by: Sagi Shahar <sagis@google.com>
>
> ---------------------------------------------
>
> Changes from v10:
> * The call to vm_tdx_load_common_boot_parameters() was accidently
> dropped as part of the refactor from v9 to v10. I re-added it here.

This can be dropped as well.

Ira

[snip]