Re: [PATCH v12 07/23] KVM: selftests: Add kbuild definitons

Reinette Chatre
2025-10-31T03:56:53Z

Hi Sagi,

typo in subject: definitons -> definitions

This is not actually a KVM selftest change though but an addition to
core tools. I do not know if such an addition can flow via the KVM tree but I
really do not think that it should be disguised as a KVM change as the
subject implies.

On 10/28/25 2:20 PM, Sagi Shahar wrote:
> Add kbuild.h that can be used by files under tools/

Similar to earlier feedback this is obvious from the patch self.

>
> Definitions are taken from the original definitions at
> include/linux/kbuild.h

Always write in imperative mood.

>
> This is needed to expose values from c code to assembly code.

I do not think this description is a strong motivation.
Another draft for consideration:

Add the kbuild definitions to enable a tool to use
the kbuild filechk_offset script to generate C header files
containing structure member offset information.

Tools depending on assembly code that operates on structures
need to hardcode the offsets of structure members. The kernel's
kbuild scripts can instead generate C header files with offset
information for inclusion into assembly code.

Reinette