Re: [PATCH v12 08/23] KVM: selftests: Define structs to pass parameters to TDX boot code

Reinette Chatre
2025-10-31T04:01:55Z

Hi Sagi,

subject nit: Define -> Declare

On 10/28/25 2:20 PM, Sagi Shahar wrote:
> TDX registers are inaccessible to KVM. Therefore we need a different

Avoid impersonating code by using "we".

> mechanism to load boot parameters for TDX code. TDX boot code will read
> the registers values from memory and set the registers manually.

Above seems to be a mix of context and summary of change. It looks like
the changelogs of this series need to be reworked to meet the KVM requirements
documented in "Changelog" section of Documentation/process/maintainer-kvm-x86.rst
highlighted by Sean.

>
> This patch defines the data structures used to communicate between c

Avoid using "this patch" - it is redundant.

> code and the TDX assembly boot code which will be added in a later
> patch.
>
> Use kbuild.h to expose the offsets into the structs from c code to
> assembly code.

Reinette