Re: [PATCH v12 15/23] KVM: selftests: Call TDX init when creating a new TDX vm

Reinette Chatre
2025-10-31T16:03:34Z

Hi Sagi,

On 10/28/25 2:20 PM, Sagi Shahar wrote:
> TDX VMs need to issue the KVM_TDX_INIT_VM ioctl after VM creation to
> initialize the TD. This ioctl also sets the cpuids and attributes for
> the VM.

"TDX VMs need to issue the KVM_TDX_INIT_VM ioctl" ... take care with the language
here since it is not the VM that issues the ioctl() (same in patch #17 changelog).

"after VM creation to initialize the TD" ... is the switching between terms
("VM" and "TD") necessary? Always referring to the same "thing" using the same
term really helps to make the text easier to read.

Finally, please do stick to imperative tone. For example,
Initialize the VM with the TDX specific parameters, such as guest CPUIDs
emulated by the TDX module, that the VM can support.

Reinette