From: "Xu, Like" <like.xu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>, peterz@infradead.org
Cc: Like Xu <like.xu@linux.intel.com>, Yao <yao.jin@linux.intel.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] KVM: x86/pmu: Add '.exclude_hv = 1' for guest perf_event
Date: Wed, 12 Aug 2020 21:14:16 +0800 [thread overview]
Message-ID: <69bac394-f10c-c0ad-a23d-36cbbd479212@intel.com> (raw)
In-Reply-To: <8bdc60d5-c9ef-4e8f-6b73-b7bd012d9d30@redhat.com>
On 2020/8/12 21:04, Paolo Bonzini wrote:
> On 12/08/20 14:56, Xu, Like wrote:
>> My proposal is to define:
>> the "hypervisor privilege levels" events in the KVM/x86 context as
>> all the host kernel events plus /dev/kvm user space events.
> What are "/dev/kvm user space events"? In any case, this patch should
> be included only in the series that adds exclude_hv support in arch/x86.
The exclude_kernel events from the QEMU or whoever else has opened /dev/kvm.
Do you see any (patches) gap if we map
the exclude_host events into exclude_hv events naturally ?
Thanks,
Like Xu
> Paolo
>
>> If we add ".exclude_hv = 1" in the pmc_reprogram_counter(),
>> do you see any side effect to cover the above usages?
>>
>> The fact that exclude_hv has never been used in x86 does help
>> the generic perf code to handle permission checks in a more concise way.
next prev parent reply other threads:[~2020-08-12 13:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 5:07 [PATCH] KVM: x86/pmu: Add '.exclude_hv = 1' for guest perf_event Like Xu
2020-08-12 10:25 ` Paolo Bonzini
2020-08-12 11:11 ` peterz
2020-08-12 11:32 ` Paolo Bonzini
2020-08-12 12:56 ` Xu, Like
2020-08-12 13:04 ` Paolo Bonzini
2020-08-12 13:14 ` Xu, Like [this message]
2020-08-12 13:31 ` peterz
2020-08-12 13:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69bac394-f10c-c0ad-a23d-36cbbd479212@intel.com \
--to=like.xu@intel.com \
--cc=acme@kernel.org \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=like.xu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox