From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7397229CB24; Tue, 21 Apr 2026 22:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776809997; cv=none; b=JaZJn2Xbh0N8y7WEoZfn85ZZXk1shyt2iIX5qg7XIVRL6HY/88gZtV/xZB7fHo63Uck60A3C/0vIP9BaTO9LGJ9JO/M0pdObBtB+4fe4+hYGh8U+eQM+0I4dNoDcLMfHz8jJgHQ00gBwgqCVEmENKctPhuHFyN+0sooZYKabkaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776809997; c=relaxed/simple; bh=D9gkMb8nHZ4E9a7ng1Zp/07VVZDP3sYFH8hxMk6N/LQ=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=Ybllu2veZHsa+MnZDZC5CCrFxThzR+evEVYdFEMM2AddFx+Oki55hCPNhpKs3Gq3a9ZFTBFOYP4/ZTUvLj8MDDfS6FRDs9S35QDhr4FCCvDms0d+V8N6VG5+l3qlqeIWcom0NK9EZk/YfwN/8eBuUXfrSEiVHNJRUKjwN5I+HP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DqPZOBpj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DqPZOBpj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 914D0C2BCB4; Tue, 21 Apr 2026 22:19:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776809997; bh=D9gkMb8nHZ4E9a7ng1Zp/07VVZDP3sYFH8hxMk6N/LQ=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=DqPZOBpj00DF6/g3uBQbo6VkOAHmGdJhmV2x5mD3flOx/0j0zoJjsCrhKNEcl8gqW 4Q/Jkqmxw7mN8uSAYzAXWtuKq4/xl+hN+APyzgNZJLzqA0gsz+wPOGfk+iNNDRFbQZ vzn61tijfDuGdFx0+ZrI2Z7TrygyTIt9cT299Y/SKleHM+c1hITIMKT7d/FdkFR2XU kUpAd+sm2ardqRHlyxbV6XKQ1ctZCWUpaURa07tMPJqZ+a8ka6psCevWy0RwKkGuIC 5zmNHNUHWNDBl63/mjNUPHClSXqnIzk3xW4WkP6SQofl/RBYH7WxRcul8D4Ayk76eg lHXohCb8Pkhpw== Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfauth.phl.internal (Postfix) with ESMTP id ADEC3F40068; Tue, 21 Apr 2026 18:19:54 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Tue, 21 Apr 2026 18:19:54 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdeivdehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefkjghfufggtgfgsehtjeertddttdejnecuhfhrohhmpeffrghnucghihhl lhhirghmshcuoegujhgsfieskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrhhnpe elhfeiudfgvdeijedtleeltdduueekffejjedvjefhgeevjeefueejledtleetjeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegujhgsfidomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudejjedvfedtgeehhedqfeeffeel gedtgeejqdgujhgsfieppehkvghrnhgvlhdrohhrghesfhgrshhtmhgrihhlrdgtohhmpd hnsggprhgtphhtthhopedujedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohephihi lhhunhdrgihusehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtoheplhhinhhugi dqtghotghosehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthhtoheplhhinhhugidq phgtihesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopeigkeeisehkvghrnh gvlhdrohhrghdprhgtphhtthhopegthhgrohdrghgrohesihhnthgvlhdrtghomhdprhgt phhtthhopegurghvvgdrjhhirghnghesihhnthgvlhdrtghomhdprhgtphhtthhopegsrg holhhurdhluheslhhinhhugidrihhnthgvlhdrtghomhdprhgtphhtthhopeihihhluhhn rdiguhesihhnthgvlhdrtghomhdprhgtphhtthhopeiihhgvnhiihhhonhhgrdguuhgrnh esihhnthgvlhdrtghomh X-ME-Proxy: Feedback-ID: i67ae4b3e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Apr 2026 18:19:53 -0400 (EDT) Date: Tue, 21 Apr 2026 15:19:52 -0700 From: Dan Williams To: Xu Yilun , linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, x86@kernel.org Cc: chao.gao@intel.com, dave.jiang@intel.com, baolu.lu@linux.intel.com, yilun.xu@linux.intel.com, yilun.xu@intel.com, zhenzhong.duan@intel.com, kvm@vger.kernel.org, rick.p.edgecombe@intel.com, dave.hansen@linux.intel.com, kas@kernel.org, xiaoyao.li@intel.com, vishal.l.verma@intel.com, linux-kernel@vger.kernel.org Message-ID: <69e7f808e9aa5_fe0831004@djbw-dev.notmuch> In-Reply-To: <20260327160132.2946114-7-yilun.xu@linux.intel.com> References: <20260327160132.2946114-1-yilun.xu@linux.intel.com> <20260327160132.2946114-7-yilun.xu@linux.intel.com> Subject: Re: [PATCH v2 06/31] x86/virt/tdx: Read global metadata for TDX Module Extensions/Connect Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Xu Yilun wrote: > Add reading of the global metadata for TDX Module Extensions & TDX > Connect. Add them in a batch as TDX Connect is currently the only user > of TDX Module Extensions and no way to initialize TDX Module Extensions > without firstly enabling TDX Connect. > > TDX Module Extensions & TDX Connect are optional features enumerated by > TDX_FEATURES0. Check the TDX_FEATURES0 before reading these metadata to > avoid failing the whole TDX initialization. I think it is important to distinguish "optional" module features vs required Linux features. Linux requires all features that a module advertises to succeed at core TDX init time. Otherwise, this looks ok / consistent with other metadata reading. It sets the precedent that if TDX Connect is advertised it must succeed all core initialization.