From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 01/15] KVM: MMU: fix the count of spte number Date: Sun, 8 Sep 2013 22:24:05 +0800 Message-ID: <6A5E49EE-3729-4825-AF31-CF03DDD92E64@gmail.com> References: <1378376958-27252-1-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <1378376958-27252-2-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <20130908121917.GH17294@redhat.com> <20130908140149.GA6468@redhat.com> Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Xiao Guangrong , avi.kivity@gmail.com, mtosatti@redhat.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mail-pa0-f49.google.com ([209.85.220.49]:43285 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751720Ab3IHOYQ convert rfc822-to-8bit (ORCPT ); Sun, 8 Sep 2013 10:24:16 -0400 In-Reply-To: <20130908140149.GA6468@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sep 8, 2013, at 10:01 PM, Gleb Natapov wrote: > On Sun, Sep 08, 2013 at 09:55:04PM +0800, Xiao Guangrong wrote: >>=20 >> On Sep 8, 2013, at 8:19 PM, Gleb Natapov wrote: >>=20 >>> On Thu, Sep 05, 2013 at 06:29:04PM +0800, Xiao Guangrong wrote: >>>> If the desc is the last one and it is full, its sptes is not count= ed >>>>=20 >>> Hmm, if desc is not full but it is not the last one all sptes after= the >>> desc are not counted too. >>=20 >> But the desc must be the last one if it's not full since we always a= dd >> new entry or delete entry from the last desc. >>=20 > Why do we alway delete entries from last desc? We delete them from th= e > desc we found them in. Current code does not try to move entries betw= een > descs, only inside a desc. Oh, yes. Sorry, my memory is wrong=85 :( So, currently there has some gaps in desc and it wastes memory. Can no= t fix them with simple change and i think it is not worthy to fix them separ= ately since after my new algorithm, these should all be fixed=85 so how about just = drop this fix?