From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] powerpc/kvm/booke: Fix build break due to stack frame size warning Date: Tue, 10 Dec 2013 03:05:02 +0100 Message-ID: <6CE89604-76E9-4875-89C7-2A6C11CD6326@suse.de> References: <1385157149-22233-1-git-send-email-scottwood@freescale.com> <6A3DF150A5B70D4F9B66A25E3F7C888D0722C6F8@039-SN2MPN1-012.039d.mgd.msft.net> <1386623900.10013.46.camel@snotra.buserror.net> Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1812\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Cc: Bharat Bhushan , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" To: Scott Wood Return-path: In-Reply-To: <1386623900.10013.46.camel@snotra.buserror.net> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 09.12.2013, at 22:18, Scott Wood wrote: > On Mon, 2013-11-25 at 04:26 -0600, Bharat Bhushan wrote: >> >>> -----Original Message----- >>> From: Wood Scott-B07421 >>> Sent: Saturday, November 23, 2013 3:22 AM >>> To: Alexander Graf >>> Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; Wood Scott-B07421; Bhushan >>> Bharat-R65777 >>> Subject: [PATCH] powerpc/kvm/booke: Fix build break due to stack frame size >>> warning >>> >>> Commit ce11e48b7fdd256ec68b932a89b397a790566031 ("KVM: PPC: E500: Add >>> userspace debug stub support") added "struct thread_struct" to the >>> stack of kvmppc_vcpu_run(). thread_struct is 1152 bytes on my build, >>> compared to 48 bytes for the recently-introduced "struct debug_reg". >>> Use the latter instead. >>> >>> This fixes the following error: >>> >>> cc1: warnings being treated as errors >>> arch/powerpc/kvm/booke.c: In function 'kvmppc_vcpu_run': >>> arch/powerpc/kvm/booke.c:760:1: error: the frame size of 1424 bytes is larger >>> than 1024 bytes >>> make[2]: *** [arch/powerpc/kvm/booke.o] Error 1 >>> make[1]: *** [arch/powerpc/kvm] Error 2 >>> make[1]: *** Waiting for unfinished jobs.... >>> >>> Signed-off-by: Scott Wood >>> Cc: Bharat Bhushan >>> --- >>> Build tested only. Bharat, please test. >> >> Tested with qemu debug stub; It works fine >> >> -Bharat > > Alex, are you going to take this through your tree? Sure. Do you want this for 3.13 or 3.14? Since I don't see the breakage with my compilers I'd queue it for 3.14, but whatever works for you works for me. Also Bharat, could you please make that a real "Tested-by" line? Alex