From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH] Compile code with "-Wwrite-strings" Date: Wed, 28 Jun 2017 22:41:51 +0200 Message-ID: <6ab255ee-f4f8-df20-e59f-ecc80f6e317a@redhat.com> References: <1498651457-19688-1-git-send-email-thuth@redhat.com> <8b1ae8b0-641a-e8cb-01e2-29fdb078caf3@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Drew Jones To: Thomas Huth , David Hildenbrand , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52962 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbdF1UmE (ORCPT ); Wed, 28 Jun 2017 16:42:04 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C95E0C04B927 for ; Wed, 28 Jun 2017 20:42:03 +0000 (UTC) In-Reply-To: <8b1ae8b0-641a-e8cb-01e2-29fdb078caf3@redhat.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 28/06/2017 22:10, Thomas Huth wrote: > On 28.06.2017 19:27, David Hildenbrand wrote: >> On 28.06.2017 14:04, Thomas Huth wrote: >>> So we make sure that we do not accidentially write to constant >> >> "accidentally" (I wouldn't know if Thunderbird wouldn't tell me ;) ) > > Oh, ok. Paolo, Radim, could you please fix it when picking up the patch? Sure. >> I assume this option has been around for quite some while, so no >> reasonable gcc will spit fire. > > A very quick search revealed that it is at least 14 years old and GCC > 4.4 already contained it. Likely even earlier versions. I think we do > not really support older versions anymore, so that should be ok. Yes, I think I've used it in GCC 2.x or so. :) Paolo >> Reviewed-by: David Hildenbrand > > Thanks! > > Thomas >